Use make-bow-stencil to simplify make-parenthesis-stencil

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#4675 Use make-bow-stencil to simplify make-parenthesis-stencil

Status: Verified

Owner: Thomas Morley

Labels: Fixed_2_19_34 (13)

Needs:

Patch:

Type:

Updated: 2016-01-03

Created: 2015-11-26

Creator: Thomas Morley

Private: No

Use make-bow-stencil to simplify make-parenthesis-stencil

Changes parentheses-item::calc-angled-bracket-stencils and
parenthesize-stencil accordingly

http://codereview.appspot.com/280750043

Discussion

Anonymous - 2015-11-27

Description has changed:

Diff:

Needs: -->

Patch: new --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-11-27

Fails make check

possibly this:

--snip--

Renaming input to: `/home/jlowe/lilypond-git/input/regression/chordnames-nochord.ly'
Interpreting music...[8]
Preprocessing graphical objects.../home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/stencil.scm:214:32: W
hile evaluating arguments to / in expression (/ line-width 2):
/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/stencil.scm:214:32: Unbound variable: line-width

--snip--

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-11-27

correct oversight

http://codereview.appspot.com/280750043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-11-28

Needs: -->

Patch: new --> review

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-11-28

Passes make, make check and a full make doc.

Reg test diff attached.

Last edit: Anonymous 2015-11-28

Reg_test.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-12-04

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-12-04

Patch on countdown for December the 7th.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-12-07

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-12-07

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-12-08

pushed to staging as

commit 7042a2704ea7b877e00846d25cf19405f9e9ba7d
Author: Thomas Morley thomasmorley65@gmail.com
Date: Thu Nov 26 14:14:28 2015 +0100

Use make-bow-stencil to simplify make-parenthesis-stencil issue 4675 Changes parentheses-item::calc-angled-bracket-stencils and parenthesize-stencil accordingly
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-12-08

labels: --> Fixed_2_19_34

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Simon Albrecht - 2016-01-03

status: Fixed --> Verified

assigned_to: Thomas Morley --> nobody
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Simon Albrecht - 2016-01-03

assigned_to: Thomas Morley
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: