Menu

#4657 Tweak Rest.staff-position fails with beam

Verified
Defect
2015-12-16
2015-11-10
No

If a beam is present, tweaking Rest.staff-position remains without effect:

:::TeX
%%% tweak-rest-staff-position-with-beam.ly
\version "2.19.28"
{
  \voiceTwo
  f'16[ \tweak staff-position 10 r16 16]
}

(Same problem with \once\override)
[EDIT: No, it’s not. Overriding works fine.]

1 Attachments

Discussion

  • David Kastrup

    David Kastrup - 2015-11-13

    I don't see "same problem with \once override": overrides seem to work fine here.

    But the tweak indeed appears to miss its mark.

     
    • Simon Albrecht

      Simon Albrecht - 2015-11-13

      Indeed, I don’t know why I wrote that. Probably I meant ‘Not an issue with \once\override’ anyway.

       
  • David Kastrup

    David Kastrup - 2015-11-13
    • status: Accepted --> Started
    • assigned_to: David Kastrup
     
  • Simon Albrecht

    Simon Albrecht - 2015-11-13
    • summary: Tweak rest.staff-position fails with beam --> Tweak Rest.staff-position fails with beam
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,4 @@
    -If a beam is present, tweaking `rest.staff-position` remains without effect:
    +If a beam is present, tweaking `Rest.staff-position` remains without effect:
    
     ~~~~
     :::TeX
    @@ -11,3 +11,4 @@
     ~~~~
    
     (Same problem with `\once\override`)
    +[EDIT: No, it’s not. Overriding works fine.]
    
     
  • David Kastrup

    David Kastrup - 2015-11-13

    Issue 4657: Tweak Rest.staff-position fails with beam

    The problem here appears to be that Beam::rest-collision-callback
    returned 0 instead of any previously established offset when it
    decided not to tamper with the default rest positioning without beam.

    This also rewrites Beam::pure-rest-collision-callback (which appears
    to have dealt correctly with the offsets here and appears
    disconcertingly diverged from the unpure callback) a bit.

    http://codereview.appspot.com/275320043

     
  • Anonymous

    Anonymous - 2015-11-14
    • Needs: -->
    • Patch: new --> review
    • Type: --> Other
     
  • Anonymous

    Anonymous - 2015-11-14

    Passes make, make check and and a full make doc.

     
  • Anonymous

    Anonymous - 2015-11-16
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2015-11-16

    Patch on countdown for November 19th.

     
  • Anonymous

    Anonymous - 2015-11-19
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2015-11-19

    Patch counted down - please push.

     
  • David Kastrup

    David Kastrup - 2015-11-19

    Pushed to staging as
    commit e8ec0112dfc34f21d01fb42538b7ce1b895fd9cc
    Author: David Kastrup dak@gnu.org
    Date: Fri Nov 13 17:54:46 2015 +0100

    Issue 4657: Tweak Rest.staff-position fails with beam
    
    The problem here appears to be that Beam::rest-collision-callback
    returned 0 instead of any previously established offset when it
    decided not to tamper with the default rest positioning without beam.
    
    This also rewrites Beam::pure-rest-collision-callback (which appears
    to have dealt correctly with the offsets here and appears
    disconcertingly diverged from the unpure callback) a bit.
    
     
  • David Kastrup

    David Kastrup - 2015-11-19
    • labels: --> Fixed_2_19_32
    • status: Started --> Fixed
    • Patch: push -->
    • Type: Other --> Defect
     
  • Phil Holmes

    Phil Holmes - 2015-12-16
    • status: Fixed --> Verified
     
MongoDB Logo MongoDB