Menu

#4656 Let concat-markup fold \char calls into surrounding strings

Verified
Enhancement
2015-12-16
2015-11-09
No

Let concat-markup fold \char calls into surrounding strings

This results in

\markup \column \box { AVA
                       \concat { A V A }
                       \concat { A \char #(char->integer #\V) A }
         }

using the same kerning in all three lines while previously the third
line differed.

http://codereview.appspot.com/272420043

Discussion

  • Anonymous

    Anonymous - 2015-11-09

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2015-11-09
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2015-11-10

    Patch on countdown for November 13th

     
  • Anonymous

    Anonymous - 2015-11-10
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2015-11-13
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2015-11-13

    Patch counted down - please push

     
  • David Kastrup

    David Kastrup - 2015-11-13
    • labels: --> Fixed_2_19_32
    • status: Started --> Fixed
    • Patch: push -->
     
  • David Kastrup

    David Kastrup - 2015-11-13

    Pushed to staging as
    commit 29756a08ce73be564baed5ab1e4bea4e3e5d9919
    Author: David Kastrup dak@gnu.org
    Date: Mon Nov 9 01:03:32 2015 +0100

    Issue 4656: Let concat-markup fold \char calls into surrounding strings
    
    This results in
    
        \markup \column \box { AVA
                               \concat { A V A }
                               \concat { A \char #(char->integer #\V) A }
                             }
    
    using the same kerning in all three lines while previously the third
    line differed.
    
     
  • Phil Holmes

    Phil Holmes - 2015-12-16
    • status: Fixed --> Verified