LilyIssues / Issues / #4640 coord-rotate should return exact values for angles like PI/2, etc

Thomas Morley - 2015-10-19

modify coord-rotate to get exact values for (sin PI) etc

issue 4640

Done by switching to appropiate values for the angle and/or switching
sin to cos and vice versa

http://codereview.appspot.com/269530043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-10-19

status: Accepted --> Started

Needs: -->

Type: --> Other
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-10-19

Type: Other --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Phil Holmes - 2015-10-20

You should find that git-cl does all this for you now: no need for all these amendments to the original issue.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Thomas Morley - 2015-10-25
  
  Using git-cl I see:
  
  ...
  This has been identified with code.google.com issue 4640.
  ...
  
  Do I have still an older version or is it a glitch?
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
  - Phil Holmes - 2015-10-25
    
    Ah - that'll be a bug that shouldn't affect the functionality - I've just forgotten to update the message.
    
    --
    Phil Holmes
    
    ----- Original Message -----
    From: Thomas Morley
    To: [testlilyissues:issues]
    Sent: Sunday, October 25, 2015 1:34 PM
    Subject: [testlilyissues:issues] Re: #4640 coord-rotate should return exact values for angles like PI/2, etc
    
    Using git-cl I see:
    
    ...
    This has been identified with code.google.com issue 4640.
    ...
    
    Do I have still an older version or is it a glitch?
    
    [issues:#4640] coord-rotate should return exact values for angles like PI/2, etc
    
    Status: Started
    Created: Mon Oct 19, 2015 11:04 PM UTC by Thomas Morley
    Last Updated: Sun Oct 25, 2015 01:24 PM UTC
    Owner: Thomas Morley
    
    coord-rotate should return exact values for angles like PI/2, etc
    
    Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/testlilyissues/issues/4640/
    
    To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/
    
    Related
    
    Issues: ~~#4640~~
    
    alternate
    
    If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-10-20

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-10-20

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-10-20

no need for code-duplications, increasing readability of cyclic-base-value

http://codereview.appspot.com/269530043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-10-20

more clean up

http://codereview.appspot.com/269530043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-10-21

Needs: -->

Patch: new --> review

Type: --> Other
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-10-21

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-10-23

Patch: review --> needs_work
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-10-23

Looks like patch needs work from the rietveld discussion

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-10-25

adressing David's comment

http://codereview.appspot.com/269530043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fixed now on github.

--
Phil Holmes

----- Original Message -----
From: Phil Holmes
To: [testlilyissues:issues]
Sent: Sunday, October 25, 2015 1:41 PM
Subject: Re: [testlilyissues:issues] Re: #4640 coord-rotate should return exact values for angles like PI/2, etc

Ah - that'll be a bug that shouldn't affect the functionality - I've just forgotten to update the message.

--
Phil Holmes

----- Original Message ----- 
From: Thomas Morley 
To: [testlilyissues:issues] 
Sent: Sunday, October 25, 2015 1:34 PM
Subject: [testlilyissues:issues] Re: #4640 coord-rotate should return exact values for angles like PI/2, etc

Using git-cl I see:

...
This has been identified with code.google.com issue 4640.
...

Do I have still an older version or is it a glitch?

[issues:#4640] coord-rotate should return exact values for angles like PI/2, etc

Status: Started
Created: Mon Oct 19, 2015 11:04 PM UTC by Thomas Morley
Last Updated: Sun Oct 25, 2015 01:24 PM UTC
Owner: Thomas Morley

coord-rotate should return exact values for angles like PI/2, etc

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/testlilyissues/issues/4640/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

alternate

Anonymous - 2015-10-26

Needs: -->

Patch: new --> review

Type: --> Other
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-10-26

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-10-29

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-10-29

Patch on countdown for November 1st 2015

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-11-01

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-11-01

Patch counted down - please push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-11-01

labels: --> Fixed_2_19_31

status: Started --> Fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Morley - 2015-11-01

pushed to staging as

commit cf11a6cd3300b5ed7e6cbe8c461adebc3bab1618
Author: Thomas Morley thomasmorley65@gmail.com
Date: Tue Oct 20 00:42:09 2015 +0200

modify coord-rotate to get exact values for (sin PI) etc issue 4640 Done by switching to appropiate values for the angle and/or switching sin to cos and vice versa Also changing cyclic-base-value from using nested if to cond for better readability
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2015-11-12

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

coord-rotate should return exact values for angles like PI/2, etc

Issue Tracker for LilyPond

Searches

Help

#4640 coord-rotate should return exact values for angles like PI/2, etc

Related

Discussion

Related