Menu

#4638 Make trailing garbage in chord mode a parser error

Verified
Enhancement
2015-11-12
2015-10-18
No

Make trailing garbage in chord mode a parser error

Previously, this was just a warning, resulting in no useful error location
for the user.

Rietveld issue: 270260043

Discussion

  • Anonymous

    Anonymous - 2015-10-19
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2015-10-19

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2015-10-20
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2015-10-20

    Patch on countdown for October 23rd.

     
  • Anonymous

    Anonymous - 2015-10-23
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2015-10-23

    Patch counted down - please push

     
  • Anonymous

    Anonymous - 2015-10-24

    author David Kastrup dak@gnu.org
    Sun, 18 Oct 2015 12:37:34 +0000 (14:37 +0200)
    committer David Kastrup dak@gnu.org
    Fri, 23 Oct 2015 16:02:16 +0000 (18:02 +0200)
    commit 041d834135d726b56d8eb13dfcbc52c6b3ce6dcf

     
  • Anonymous

    Anonymous - 2015-10-24
    • labels: --> Fixed_2_19_30
    • status: Started --> Fixed
    • Patch: push -->
     
  • Federico Bruni

    Federico Bruni - 2015-11-06

    not in master yet, fixed version changed

     
  • Federico Bruni

    Federico Bruni - 2015-11-06
    • labels: Fixed_2_19_30 --> Fixed_2_19_31
     
  • Federico Bruni

    Federico Bruni - 2015-11-12
    • status: Fixed --> Verified
     
  • Federico Bruni

    Federico Bruni - 2015-11-12

    my gitk seems broken (can't find any committish)
    I wonder why this one seems present in two tags:

    $ git tag --contains 041d834135d726b56d8eb13dfcbc52c6b3ce6dcf
    release/2.19.30-1
    release/2.19.31-1