Menu

#4627 Convert Scheme_hash_table to using Smob1

Verified
Maintainability
2015-10-20
2015-10-05
No

Convert Scheme_hash_table to using Smob1

That reduces its memory and access footprint. The unused copy
constructor is removed altogether as the use of Smob1 would require
different semantics.

Rietveld issue: https://codereview.appspot.com/264650043

Discussion

  • Anonymous

    Anonymous - 2015-10-05

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2015-10-05
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2015-10-08

    Patch on countdown for Oct 11th.

     
  • Anonymous

    Anonymous - 2015-10-08
    • Patch: review --> countdown
     
  • Trevor Daniels

    Trevor Daniels - 2015-10-08
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -4,4 +4,4 @@
     constructor is removed altogether as the use of Smob1 would require
     different semantics.
    
    -Rietveld issue: 264650043 (https://codereview.appspot.com/264650043)
    +Rietveld issue: [https://codereview.appspot.com/264650043](https://codereview.appspot.com/264650043)
    
     
  • Anonymous

    Anonymous - 2015-10-11

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2015-10-11
    • Patch: countdown --> push
     
  • David Kastrup

    David Kastrup - 2015-10-11

    Pushed to staging as
    commit cfc908430e67711a28a33097aaea491f7c127a72
    Author: David Kastrup dak@gnu.org
    Date: Tue Jun 16 08:07:45 2015 +0200

    Issue 4627: Convert Scheme_hash_table to using Smob1
    
    That reduces its memory and access footprint.  The unused copy
    constructor is removed altogether as the use of Smob1 would require
    different semantics.
    
     
  • David Kastrup

    David Kastrup - 2015-10-11
    • labels: --> Fixed_2_19_29
    • status: Started --> Fixed
    • Patch: push -->
     
  • Phil Holmes

    Phil Holmes - 2015-10-20
    • status: Fixed --> Verified