Menu ▾ ▴

#4625 Support slurs starting and/or ending on individual notes in chords

Verified
David Kastrup
Fixed_2_19_29 (16)
Enhancement
2015-10-20
2015-10-02
David Kastrup
No

Support slurs starting and/or ending on individual notes in chords

Sorry, I can't actually come up with satisfactory examples right now.
Please find something in Chopin or so. I'm sure we discussed this on
the mailing list at some point of time.

Output is still rather rough. Basics are there now, but the finetuning leaves a lot to be desired.

Contains commits:

Accept note heads as slur bounds

Also changes base_attachment calculation for in-chord slurs.

Move in-chord slur info to slur boundaries

Listen to and record in-chord slurs

Add event_symbol function to all slur engravers

Rename Slur_proto_engraver::internal_listen_slur to listen_slur

That's more in line with how we divert to base class functions elsewhere.

Rietveld issue: https://codereview.appspot.com/265370043

Discussion

  • Anonymous

    Anonymous - 2015-10-02
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2015-10-02

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2015-10-05
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2015-10-05

    Patch on countdown for October 8th

     

  • Anonymous

    Anonymous - 2015-10-08
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2015-10-08

    Patch counted down - please push.

     

  • Trevor Daniels

    Trevor Daniels - 2015-10-08
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -26,4 +26,4 @@

 That's more in line with how we divert to base class functions elsewhere.

-Rietveld issue: 265370043 (https://codereview.appspot.com/265370043)
+Rietveld issue: [https://codereview.appspot.com/265370043](https://codereview.appspot.com/265370043)
     

  • David Kastrup

    David Kastrup - 2015-10-08
    • labels: --> Fixed_2_19_29
    • status: Started --> Fixed
    • Patch: push -->
     

  • David Kastrup

    David Kastrup - 2015-10-08

    Pushed to staging as
    commit 918231bde3dd1cb29865b5f29ee3c1fadee93935
    Author: David Kastrup dak@gnu.org
    Date: Sat Oct 3 20:31:28 2015 +0200

    Issue 4625/6: NR: mention in-chord slurs in Simultaneous Music

    commit ac651504b3fc09a6146cef552ff2ef49c22e71e9
    Author: David Kastrup dak@gnu.org
    Date: Tue Nov 4 13:27:40 2014 +0100

    Issue 4625/5: Accept note heads as slur bounds

Also changes base_attachment calculation for in-chord slurs.

    commit eee5583d9b8b6ff3187060aa48120e4544d2af58
    Author: David Kastrup dak@gnu.org
    Date: Thu Oct 1 12:34:15 2015 +0200

    Issue 4625/4: Move in-chord slur info to slur boundaries

    commit 77c3a9bc4eb145bf9a8e6025edd6eea43e8e3331
    Author: David Kastrup dak@gnu.org
    Date: Wed Dec 10 18:44:16 2014 +0100

    Issue 4625/3: Listen to and record in-chord slurs

    commit 6f95e02682255e985808947461fafcc5fcc3f060
    Author: David Kastrup dak@gnu.org
    Date: Wed Sep 30 22:00:37 2015 +0200

    Issue 4625/2: Add event_symbol function to all slur engravers

    commit 6754d3302bcce74ef78c27defc3e8900be27b4f8
    Author: David Kastrup dak@gnu.org
    Date: Wed Sep 30 22:58:43 2015 +0200

    Issue 4625/1: Rename Slur_proto_engraver::internal_listen_slur to listen_slur

That's more in line with how we divert to base class functions elsewhere.
     

  • Phil Holmes

    Phil Holmes - 2015-10-20
    • status: Fixed --> Verified