Menu

#4622 Patch: create a <Part-combiner> class

Started
Dan Eble
None
needs_work
Maintainability
2015-10-03
2015-09-26
Dan Eble
No

<part-combiner> collects in one place the options for routing parts to Voice contexts and generating marks.</part-combiner>

\partcombine, \partcombineUp, and \partcombineDown accept an optional <part-combiner> in place of an optional chord range, though this is not yet documented.</part-combiner>

This makes customization significantly easier than before.

https://codereview.appspot.com/265260043/

Discussion

  • Dan Eble

    Dan Eble - 2015-09-26

    Patch updated to avoid changing the interface of \partcombine etc.
    https://codereview.appspot.com/265260043/

     
  • Anonymous

    Anonymous - 2015-09-26

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2015-09-26
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2015-09-29
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2015-09-29

    Patch on countdown for October 2nd.

     
  • Anonymous

    Anonymous - 2015-10-02

    There seems to be some discussion here, I'll set this back to review for now.

     
  • Anonymous

    Anonymous - 2015-10-02
    • Patch: countdown --> review
     
  • Dan Eble

    Dan Eble - 2015-10-03
    • Patch: review --> needs_work
    • Type: Enhancement --> Maintainability
     
  • Dan Eble

    Dan Eble - 2015-10-03

    I need time to digest the review comments.

     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.