#4618 Correct argument handling of `Unpure_pure_call::call`

[Simon Albrecht]

Owner: dak@gnu.org

When ly:make-unpure-pure-container is called with a single procedure
argument, this procedure is used for both unpure and pure calls. It
turns out that the calling convention in call_pure_function places the
start/end arguments always in position 2/3 of the call.
Unpure_pure_call::call previously always dropped the last 2 arguments of
a pure call before passing the rest on. Most calls take exactly 3
arguments (grob start end) where this does not make a difference, but
there may be use cases with a different number of arguments.

Rietveld issue: 262500043

[Anonymous]

Passes make, make check and a full make doc.

[Simon Albrecht]

New patchset, which consists of commits:

• Rewrite call_pure_function
• Remove node "simple closure" from notation appendices
• Remove/replace Simple_closure smob type
• Import grob::compose-function and grob::offset-function into C
• Add grob::compose-function and grob::offset-function
  Those are the main replacements for the uses of ly:make-simple-closure
  in lily/grob-closure.cc.
• Add ly:pure-call and ly:unpure-call functions
• Remove unused function chain-grob-member-functions

[Simon Albrecht]

Reverting changes. The other commits now are grouped in issue 4620.

[Anonymous]

Patch on countdown for September 29th.

[Anonymous]

Patch counted down - please push.

[David Kastrup]

Pushed to staging as

commit 7b8fc6cb7d8ed1b072b7027ad5035ff90f8dfabc
Author: David Kastrup <dak@gnu.org>
Date:   Wed Sep 23 21:50:39 2015 +0200

    Issue 4618: Correct argument handling of Unpure_pure_call::call

    When ly:make-unpure-pure-container is called with a single procedure
    argument, this procedure is used for both unpure and pure calls.  It
    turns out that the calling convention in call_pure_function places the
    start/end arguments always in position 2/3 of the call.
    Unpure_pure_call::call previously always dropped the last 2 arguments of
    a pure call before passing the rest on.  Most calls take exactly 3
    arguments (grob start end) where this does not make a difference, but
    there may be use cases with a different number of arguments.