Menu

#4615 Don't center letter fret labels but align them at their baseline

Verified
Ugly
2015-11-12
2015-09-21
No

Owner: David Kastrup (dak@gnu.org)

Not sure this change of behavior is really wanted or the chosen value
will be useful/appropriate. This particular change is in
scm/translation-functions.scm. The issue contains another commit that
is independently useful as it stops the redundantly hardwired behavior
established in tab-note-head::print :

Make TabNoteHead.X-offset operative

It has been effectively overridden in tab-note-head::print which
masked the missing default of self-alignment-X.

Rietveld issue: 262470043

Discussion

  • Anonymous

    Anonymous - 2015-09-21
    • Patch: new --> review
     
  • Simon Albrecht

    Simon Albrecht - 2015-09-21
    • Patch: review --> needs_work
     
  • Simon Albrecht

    Simon Albrecht - 2015-09-21

    David said:

    The regtests clearly show horizontal centering of TabNoteHead not working at all.

     

    Last edit: Simon Albrecht 2015-09-21
  • Trevor Daniels

    Trevor Daniels - 2015-10-27
    • assigned_to: David Kastrup
     
  • David Kastrup

    David Kastrup - 2015-10-27

    Just bother with vertical alignment, horizontal is too messed up

    http://codereview.appspot.com/262470043

     
  • Anonymous

    Anonymous - 2015-10-28

    Passes make, make check and a full make doc.

    Reg test diff attached

     
  • Anonymous

    Anonymous - 2015-10-28
    • Needs: -->
    • Patch: new --> review
    • Type: --> Other
     
  • Anonymous

    Anonymous - 2015-10-28

    Attached reg test diff

     
    • David Kastrup

      David Kastrup - 2015-10-28

      That's pretty much expected: letter tablature uses baseline alignment now. For the half-height letters there, the change is pretty small and appears to work pretty well. The difference is most noticeable with "b" and gamma.

       
  • Anonymous

    Anonymous - 2015-10-29

    Patch on countdown for November 1st 2015

     
  • Anonymous

    Anonymous - 2015-10-29
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2015-11-01

    Patch counted down - please push

     
  • Anonymous

    Anonymous - 2015-11-01
    • Patch: countdown --> push
     
  • David Kastrup

    David Kastrup - 2015-11-01

    Pushed to staging as
    commit 3b322e2bf09b761f165c09a7f5ee83e282dcd1d2
    Author: David Kastrup dak@gnu.org
    Date: Mon Sep 21 18:01:35 2015 +0200

    Issue 4615: Don't center letter fret labels but align them at their baseline
    

    commit 0e4e1a56b7196523a1812c1d969e2f871f693ace
    Author: David Kastrup dak@gnu.org
    Date: Tue Oct 27 22:52:00 2015 +0100

    Save an unnecessary double calculation in tab-note-head::print
    
     
  • David Kastrup

    David Kastrup - 2015-11-01
    • labels: --> Fixed_2_19_31
    • status: Started --> Fixed
    • Patch: push -->
    • Type: Other --> Ugly
     
  • Federico Bruni

    Federico Bruni - 2015-11-12
    • status: Fixed --> Verified
     
MongoDB Logo MongoDB