Menu

#4614 Make interpretation of `\chordmode { c:sus c:5 }` more conventional

Verified
Enhancement
2015-10-05
2015-09-20
No

Owner: David Kastrup (dak@gnu.org)

Contains commits:

  • Run scripts/auxiliar/makelsr.py
  • Amend snippet single-staff-template-with-notes-and-chords.ly
  • Change NR to reflect new equivalence of sus and sus4
  • Change NR to reflect new equivalence of c:5 and c:1.5
  • Run scripts/auxiliar/update-with-convert-ly.sh
  • convert-ly rule c:5.x, c:5^x, c:sus -> c:3.5.x, c:3.5^x, c:5
  • Let \chordmode { c:5 } mean <c' g'> rather than <c' e' g'>
  • Let c:sus be interpreted as c:sus4

Rietveld issue: 263280043

Discussion

  • Anonymous

    Anonymous - 2015-09-20

    Passes make, make check and a full make doc

     
  • Anonymous

    Anonymous - 2015-09-20
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2015-09-23

    Patch on countdown for September 26th.

     
  • Anonymous

    Anonymous - 2015-09-23
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2015-09-26

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2015-09-26
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2015-09-26
    • labels: --> FIxed_2_19_28
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2015-09-26

    Issue 4614 [Make interpretation of \chordmode { c:sus c:5 } more conventional]
    Status: Fixed
    Tag: Fixed_2_19_28
    Comment:
    Pushed to staging as merge commit
    * commit a226ead901d6717c99f728c6959af46734117e7b
    |\ Merge: 43e591c b61b2fc
    | | Author: David Kastrup dak@gnu.org
    | | Date: Sat Sep 26 12:33:24 2015 +0200
    | |
    | | Merge branch 'issue4614' into HEAD
    | |
    | * commit b61b2fccd68e0023164edde737ba6927fc7aa2bf
    | | Author: David Kastrup dak@gnu.org
    | | Date: Sun Sep 20 18:12:04 2015 +0200
    | |
    | | Run scripts/auxiliar/makelsr.py
    | |
    | * commit d30e3c1c699f5b84424b76ebf0ab944490015886
    | | Author: David Kastrup dak@gnu.org
    | | Date: Sun Sep 20 18:10:51 2015 +0200
    | |
    | | Issue 4614/6: Amend snippet single-staff-template-with-notes-and-chords.ly
    | |
    | * commit 828310574b05b95170920eabb8142bf0e8f23182
    | | Author: David Kastrup dak@gnu.org
    | | Date: Sun Sep 20 17:56:29 2015 +0200
    | |
    | | Issue 4614/5: Change NR to reflect new equivalence of sus and sus4
    | |
    | * commit 06d6a13aa91ff4d49c052462251f2ece96374f79
    | | Author: David Kastrup dak@gnu.org
    | | Date: Sun Sep 20 15:04:48 2015 +0200
    | |
    | | Issue 4614/4: Change NR to reflect new equivalence of c:5 and c:1.5
    | |
    | * commit f7dfb61e546cb03d61d92271839288c44abf8aed
    | | Author: David Kastrup dak@gnu.org
    | | Date: Sun Sep 20 17:44:47 2015 +0200
    | |
    | | Run scripts/auxiliar/update-with-convert-ly.sh
    | |
    | * commit 2bfeb6186a202b5e228c491ea7e44040ae75589f
    | | Author: David Kastrup dak@gnu.org
    | | Date: Sun Sep 20 16:40:47 2015 +0200
    | |
    | | Issue 4614/3: convert-ly rule c:5.x, c:5^x, c:sus -> c:3.5.x, c:3.5^x, c:5
    | |
    | * commit 6530812dbeecdd112f4fcf94e6d362090a5af2a6
    | | Author: David Kastrup dak@gnu.org
    | | Date: Sat Sep 19 14:28:57 2015 +0200
    | |
    | | Issue 4614/2: Let \chordmode { c:5 } mean <c' g'=""> rather than <c' e'="" g'="">
    | |
    | * commit a57c72d1461560a1d06212808ad10fd63e5ef4d4
    |/ Author: David Kastrup dak@gnu.org
    | Date: Sat Sep 19 19:26:54 2015 +0200
    |
    | Issue 4614/1: Let c:sus be interpreted as c:sus4

    So let's see what kind of feedback we get for that change.

    --
    David Kastrup

     
  • Trevor Daniels

    Trevor Daniels - 2015-10-02
    • assigned_to: David Kastrup
     
  • Trevor Daniels

    Trevor Daniels - 2015-10-05
    • status: Fixed --> Verified
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.