Don't let AccidentalPlacement::add_accidental rewrite X-offset

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#4612 Don't let AccidentalPlacement::add_accidental rewrite X-offset

Status: Verified

Owner: David Kastrup

Labels: Fixed_2_19_28 (14)

Needs:

Patch:

Type: Enhancement

Updated: 2015-10-05

Created: 2015-09-17

Creator:

Private: No

Type: Maintainability
Owner: dak@gnu.org
Status: Started
Patch: new
Summary:
Don't let AccidentalPlacement::add_accidental rewrite X-offset

It does not seem necessary, obfuscates matters and precludes use of \offset.

Rietveld issue: 268860043

--
David Kastrup

Discussion

Anonymous - 2015-09-17

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-09-17

https://codereview.appspot.com/268860043

Passes make, make check and a full make doc

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-09-20

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-09-20

Patch on countdown for Septmeber 23rd

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-09-23

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-09-23

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-09-24

labels: --> Fixed_2_19_28

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2015-09-24

author David Kastrup dak@gnu.org
Thu, 17 Sep 2015 16:22:39 +0000 (18:22 +0200)
committer David Kastrup dak@gnu.org
Wed, 23 Sep 2015 12:54:41 +0000 (14:54 +0200)
commit 6defe33388b630e1f2aa5b76c9b6eecfd0607343

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trevor Daniels - 2015-10-02

assigned_to: David Kastrup
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trevor Daniels - 2015-10-05

Description has changed:

Diff:

--- old +++ new @@ -8,7 +8,7 @@ It does not seem necessary, obfuscates matters and precludes use of \offset. -Rietveld issue: 268860043 (https://codereview.appspot.com/268860043) +[Rietveld issue: 268860043](https://codereview.appspot.com/268860043) -- David Kastrup

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: