#4610 ly:round-filled-polygon: optional parameter `extroversion'

[Simon Albrecht]

Owner: dak@gnu.org

`extroversion' specifies where on the specified outline to draw with the
pen of the given thickness. Its default of -1 corresponds to the
previous behavior of drawing strictly inside of the given polygon. An
extroversion value of 0 draws exactly along the given polygon, and a
value of 1 will draw just outside of the given polygon.

Rietveld issue: 261300043

[Anonymous]

Fails make - almost immediately...

--snip--

rm -f ./out/measure-grouping-spanner.dep; DEPENDENCIES_OUTPUT="./out/measure-grouping-spanner.dep ./out/measure-grouping-spanner.o" g++ -c -Woverloaded-virtual -I/usr/include/python2.7 -I/usr/include/x86_64-linux-gnu/python2.7 -fno-strict-aliasing -g -fstack-protector --param=ssp-buffer-size=4 -g -fwrapv -DHAVE_CONFIG_H -DDEBUG -I/home/jlowe/lilypond-git/lily/include -I./out -I/home/jlowe/lilypond-git/flower/include -I../flower/./out -I../flower/include -I/home/jlowe/lilypond-git/lily/out -g -pipe -pthread -I/usr/include/freetype2 -pthread -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -W -Wall -Wconversion -o out/measure-grouping-spanner.o /home/jlowe/lilypond-git/lily/measure-grouping-spanner.cc
rm -f ./out/mensural-ligature.dep; DEPENDENCIES_OUTPUT="./out/mensural-ligature.dep ./out/mensural-ligature.o" g++ -c -Woverloaded-virtual -I/usr/include/python2.7 -I/usr/include/x86_64-linux-gnu/python2.7 -fno-strict-aliasing -g -fstack-protector --param=ssp-buffer-size=4 -g -fwrapv -DHAVE_CONFIG_H -DDEBUG -I/home/jlowe/lilypond-git/lily/include -I./out -I/home/jlowe/lilypond-git/flower/include -I../flower/./out -I../flower/include -I/home/jlowe/lilypond-git/lily/out -g -pipe -pthread -I/usr/include/freetype2 -pthread -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -W -Wall -Wconversion -o out/mensural-ligature.o /home/jlowe/lilypond-git/lily/mensural-ligature.cc
/home/jlowe/lilypond-git/lily/lookup.cc: In function 'Stencil Lookup::round_filled_polygon(const std::vector<offset>&, Real, Real)':
/home/jlowe/lilypond-git/lily/lookup.cc:256:26: warning: conversion to 'int' from 'vsize {aka long unsigned int}' may alter its value [-Wconversion]
int next = (i + 1) % points.size ();
^
/home/jlowe/lilypond-git/lily/lookup.cc:297:30: warning: conversion to 'Real {aka double}' from 'std::vector<offset>::size_type {aka long unsigned int}' may alter its value [-Wconversion]
center /= points.size ();
^
/home/jlowe/lilypond-git/lily/lookup.cc:315:20: warning: conversion to 'int' from 'vsize {aka long unsigned int}' may alter its value [-Wconversion]
int i0 = i;
^
/home/jlowe/lilypond-git/lily/lookup.cc:316:28: warning: conversion to 'int' from 'vsize {aka long unsigned int}' may alter its value [-Wconversion]
int i1 = (i + 1) % points.size ();
^
/home/jlowe/lilypond-git/lily/lookup.cc:317:28: warning: conversion to 'int' from 'vsize {aka long unsigned int}' may alter its value [-Wconversion]
int i2 = (i + 2) % points.size ();
^
/home/jlowe/lilypond-git/lily/lookup.cc:390:1: error: a function-definition is not allowed here before '{' token
{
^
/home/jlowe/lilypond-git/lily/lookup.cc:635:1: error: expected '}' at end of input
}
^
/home/jlowe/lilypond-git/lily/lookup.cc:635:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
make[1]: *** [out/lookup.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/jlowe/lilypond-git/build/lily'</offset></offset>

[Simon Albrecht]

David says:

Add missing brace. No idea how this escaped testing.

[Anonymous]

Passes make, make check and a full make doc.

[Anonymous]

Patch on countdown for October 2nd.

[Anonymous]

Patch counted down - pleae push.

[David Kastrup]

Pushed to staging as
commit ea03bb1d323aef010eea00c1709d3dab56c0bf0b
Author: David Kastrup dak@gnu.org
Date: Thu Aug 13 15:30:43 2015 +0200

Issue 4610: ly:round-filled-polygon: optional parameter `extroversion'

`extroversion' specifies where on the specified polygon to draw with the
pen of the given thickness.  Its default of -1 corresponds to the
previous behavior of drawing strictly inside of the given polygon.  An
extroversion value of 0 draws exactly along the given polygon, and a
value of 1 will draw just outside of the given polygon.