Menu

#4563 PATCH: Change PDF 'author' field to use /Author not /Composer

Verified
Enhancement
2015-10-02
2015-08-15
Anonymous
No

Originally created by: *anonymous

Originally created by: pkx1...@gmail.com

Currently, the PDF author field is filled with the composer. This is nice fall back but in most cases the author of the document and the composer will be different. While I can write pdfcomposer = "Author Name" it appears as intended as /Author(Author Name) but it also appears as /Composer(Author Name) which is wrong. Wouldn't it make sense to offer both fields: Author and Composer separately? A fallback if no author is given makes sense but it would be good to be able to specify an author differing from the composer.

https://codereview.appspot.com/260200043

Discussion

  • Google Importer

    Google Importer - 2015-08-15

    Originally posted by: pkx1...@gmail.com

    This passes make, make check and a full make doc. However reg tests show programming errors

    for example

    --snip--

    Writing ./voice-4-midi-systems.tex...
    Writing ./voice-4-midi-systems.count...
    Writing timing to voice-4-midi.profile...
    +programming error: Parsed object should be dead: #<Context_def CueVoice /home/james/lilypond-git/build/out/share/lilypond/current/ly/performer-init.ly:110:1>
    +continuing, cross fingers
    +programming error: Parsed object should be dead: #<Prob: Music C++: Music((origin . #<location out-test/voice-4-midi.ly:72:3>))((display-methods #<procedure #f (check)>) (name . BarCheck) (types bar-check) (iterator-ctor . #<primitive-procedure ly:bar-check-iterator::constructor>)) >
    +
    +continuing, cross fingers

    input/regression/midi/voice-4-midi.log

    --snip--

    MOst (if not all of the Midi reg tests show this same error)

    Labels: -Patch-new Patch-needs_work

     
  • Phil Holmes

    Phil Holmes - 2015-08-30

    I've created a new patch for this at:

    https://codereview.appspot.com/264970043/

    This uses author and pdfauthor as the normal fields to set Author in the PDF properties.

     
  • Phil Holmes

    Phil Holmes - 2015-08-30
    • Description has changed:

    Diff:

    
    
    • assigned_to: Phil Holmes
    • Needs: -->
    • Patch: needs_work --> review
     
  • Phil Holmes

    Phil Holmes - 2015-08-30

    I've created a new patch for this at:

    https://codereview.appspot.com/264970043/

    This uses author and pdfauthor as the normal fields to set Author in the PDF properties.

     
  • Anonymous

    Anonymous - 2015-08-31

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2015-08-31
    • Patch: new --> review
     
  • Anonymous

    Anonymous - 2015-09-02
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2015-09-02

    Patch on countdown for September 5th

     
  • Anonymous

    Anonymous - 2015-09-05

    Patch counted down - please push

     
  • Anonymous

    Anonymous - 2015-09-05
    • Patch: countdown --> push
     
  • Phil Holmes

    Phil Holmes - 2015-09-06

    Pushed to staging as 9cd96a9f2f66f8182099079685456a6e23c26862

     
  • Phil Holmes

    Phil Holmes - 2015-09-06
    • labels: --> Fixed_2_19_27
    • status: Started --> Fixed
     
  • Trevor Daniels

    Trevor Daniels - 2015-09-08
    • Patch: push -->
     
  • Trevor Daniels

    Trevor Daniels - 2015-10-02
    • status: Fixed --> Verified