Menu

#4544 Fix LilyPond default fonts definition

Verified
nobody
Enhancement
2015-09-04
2015-08-08
Anonymous
No

Originally created by: *anonymous

Originally created by: truer...@gmail.com
Originally owned by: truer...@gmail.com

Due to conf file loading order, generic font aliases
`serif', `sans-serif', 'monospace' were unavailable
in LilyPond default fonts definition.
So the glyphs that are not contained
in the list of font definition,
like Japanese glyphs were used unexpected font.

This commit changes
LilyPond default fonts definition loading order
for enabling the aliases.

https://codereview.appspot.com/258160043/

Related

Issues: #4552

Discussion

  • Google Importer

    Google Importer - 2015-08-08

    Originally posted by: pkx1...@gmail.com

    When I try to patch the source code I get this:

    --snip--

    patching file mf/lilypond-fonts.conf.in
    patching file GNUmakefile.in
    patching file lily/font-config.cc
    Cannot rename file without two valid file names
    1 out of 1 hunk ignored
    patching file mf/99-lilypond-fonts.conf.in
    patching file mf/GNUmakefile
    patching file scm/font.scm

    --snip--

    So I am not sure the code changes have applied.

    Can you check your side please?

    Labels: -Patch-new Patch-needs_work

     
  • Google Importer

    Google Importer - 2015-08-09

    Originally posted by: truer...@gmail.com

    Perhaps it is upload.py's problem.
    I've fixed upload.py and uploaded again.

    Labels: -Patch-needs_work Patch-new

     
  • Google Importer

    Google Importer - 2015-08-09

    Originally posted by: truer...@gmail.com

    I've uploaded Patch Set 4.
    It fixes makefile ln error.

    https://codereview.appspot.com/258160043/

     
  • Google Importer

    Google Importer - 2015-08-10

    Originally posted by: pkx1...@gmail.com

    passes make, make check and a full make doc. Reg test diff attached

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2015-08-10

    Originally posted by: pkx1...@gmail.com

    Patch on countdown for August 11th

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2015-08-13

    Originally posted by: pkx1...@gmail.com

    Patch counted down - please push.

    Labels: -Patch-countdown Patch-push

     
  • Google Importer

    Google Importer - 2015-08-14

    Originally posted by: truer...@gmail.com

    I've pushed to staging.

    Issue 4544 / 1: Divide LilyPond local fontconfig conf file loading
    author    Masamichi Hosoda <trueroad@trueroad.jp>
              Sat, 8 Aug 2015 13:16:41 +0000 (22:16 +0900)
    committer Masamichi Hosoda <trueroad@trueroad.jp>
              Fri, 14 Aug 2015 10:47:42 +0000 (19:47 +0900)
    commit    [r62a6e9aef6f164641a4ac57e3342b7917c6a53b0]

    Issue 4544 / 2: Fix LilyPond default fonts definition
    author    Masamichi Hosoda <trueroad@trueroad.jp>
              Sat, 8 Aug 2015 10:06:50 +0000 (19:06 +0900)
    committer Masamichi Hosoda <trueroad@trueroad.jp>
              Fri, 14 Aug 2015 10:47:42 +0000 (19:47 +0900)
    commit    [r0fbbdc6c58432060770d3d4f76e063c2028c0023]

    Issue 4544 / 3: Fix makefiles for LilyPond local fontconfig conf file dividing
    staging
    author    Masamichi Hosoda <trueroad@trueroad.jp>
              Sat, 8 Aug 2015 12:15:37 +0000 (21:15 +0900)
    committer Masamichi Hosoda <trueroad@trueroad.jp>
              Fri, 14 Aug 2015 10:47:43 +0000 (19:47 +0900)
    commite   bd5a4af248c95178abb8490a32c0b8d3af4e1d7

    Labels: -Patch-push Fixed_2_19_26
    Status: Fixed

     
  • Colin Campbell

    Colin Campbell - 2015-09-04
    • Description has changed:

    Diff:

    
    
    • status: Fixed --> Verified
    • Needs: -->
    • Patch: -->