Menu
▾
▴
#4517 merely loading articulate.ly should not change default output
Originally created by: *anonymous
Originally created by: fedel...@gmail.com
Originally owned by: dak@gnu.org
David commented:
"The problem as I understand it is that the output is altered even without using the \articulate command. That should be fixed so that it does not matter where you load articulate.ly as long as you don't call \articulate."
Even though there's no meaning in including articulate.ly and then not using \articulate.
As of issue 4381 we recommend using two score blocks, putting the articulate include after the score block for PDF and before the score block for MIDI.
This issue should avoid this need, IIUC.
Related
Discussion
Originally posted by: dak@gnu.org
I disagree with "Even though there's no meaning in including articulate.ly and then not using \articulate". Most certainly there is meaning in including articulate.ly and _not_ using it on _every_ single following expression. The purpose of including articulate.ly is to _provide_ the \articulate command, not to _mandate_ the articulate command. If it were the latter, we could add it to toplevel-music-functions and have it applied unconditionally.
Originally posted by: pkx1...@gmail.com
Can I just check please, are you implying issue 4381 is 'invalid' or should it continue on through the countdown?
Related
Issues:
#4381Originally posted by: dak@gnu.org
Issue 4517: merely loading articulate.ly should not change default output
Also contains commit:
display-lily.scm: export with-music-match
http://codereview.appspot.com/254350043
Summary: merely loading articulate.ly should not change default output
Owner: dak@gnu.org
Labels: Patch-new
Status: Started
Related
Issues:
#4517Originally posted by: pkx1...@gmail.com
Passes make, make check and a full make doc
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
There's a small 'changelog' in that articulate.ly file (as a comment) is it worth adding this to that as well?
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
You caught me there. It's not just "worth" it but rather a requirement according to the GPLv3 since articulate.ly is licensed independently from LilyPond.
I'll do so presently but it should not hold up the review process or require additional testing.
Originally posted by: dak@gnu.org
Augment file-internal change log
In-comment change only, no new tests required.
http://codereview.appspot.com/254350043
Originally posted by: pkx1...@gmail.com
Patch on countdown for July 30th.
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1...@gmail.com
Patch counted down - please push
Labels: -Patch-countdown Patch-push
Originally posted by: dak@gnu.org
Pushed to staging as
commit [r55ea0719e3383f52cec434c6fcb5e6776b741d48]
Author: David Kastrup <dak@gnu.org>
Date: Thu Jul 23 18:15:18 2015 +0200
Issue 4517: merely loading articulate.ly should not change default output
commit [raa1758a0d2f9c82f154128873929e62f4ccb5af2]
Author: David Kastrup <dak@gnu.org>
Date: Thu Jul 23 20:01:13 2015 +0200
display-lily.scm: export with-music-match
Labels: -Patch-push Fixed_2_19_25
Status: Fixed
Related
Issues:
#4517Diff:
Diff:
.