Menu

#4505 Add partial \override and \set commands

Verified
nobody
Enhancement
2015-09-03
2015-07-14
Anonymous
No

Originally created by: *anonymous

Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org

Add partial \override and \set commands

This allows \set and \override commands to be stopped short after
their `=' sign in order to be used in the manner of partial music
functions.

In order to make this currently reviewable, this is based off the
combined patches for issue 4488, issue 4486, issue 4487, issue 4498
(all currently on countdown) which form the first patch in the
Rietveld review (it's more than a simple rebase since issue 4488 in
particular allows simplifying the parallelly reviewed issues).

Also contains marginally related commit:

Reorganize argument list for Syntax::partial-music-function

This one should have likely been done from the start for issue 4487
but I don't want to stop the countdown for this cleanup.

http://codereview.appspot.com/255190043

Related

Issues: #2453
Issues: #4486
Issues: #4487
Issues: #4488
Issues: #4498
Issues: #4505
Issues: #4514
Issues: #4523
Issues: #4529

Discussion

  • Google Importer

    Google Importer - 2015-07-15

    Originally posted by: pkx1...@gmail.com

    Passes make, make check and a full make doc

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2015-07-17

    Originally posted by: pkx1...@gmail.com

    Patch on countdown for July 21st

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2015-07-20

    Originally posted by: pkx1...@gmail.com

    Patch counted down - please push.

    Labels: -Patch-countdown Patch-push

     
  • Google Importer

    Google Importer - 2015-07-20

    Originally posted by: dak@gnu.org

    Pushed to staging as
    commit [r47ce0f0eb601fd3d8fd38e9782e74e21c8b76205]
    Author: David Kastrup <dak@gnu.org>
    Date:   Sun Jul 12 18:16:58 2015 +0200

        Issue 4505: Add partial \override and \set commands
       
        This allows \set and \override commands to be stopped short after
        their `=' sign in order to be used in the manner of partial music
        functions.

    commit [r6ec61abd275a527807dd64bd216e1c5e6b8b74f3]
    Author: David Kastrup <dak@gnu.org>
    Date:   Tue Jul 14 15:56:04 2015 +0200

        Reorganize argument list for Syntax::partial-music-function

    Labels: -Patch-push Fixed_2_19_24
    Status: Fixed

     

    Related

    Issues: #4505

  • Google Importer

    Google Importer - 2015-07-21

    Originally posted by: dak@gnu.org

    This doesn't even work, due to propertyOverride and propertySet not being defined in the (lily) module but in the parser.

    How awkward.  No idea how this slipped through my radar.  Reverting the last commit of the patch and redoing it differently.  And I'll probably add something to the C++ module access system that will catch this particular error condition at build time already.

    Labels: -Fixed_2_19_24 Patch-needs_work
    Status: Started

     
  • Google Importer

    Google Importer - 2015-07-21

    Originally posted by: dak@gnu.org

    Issue 4505: Add partial \override and \set commands

    This allows \set and \override commands to be stopped short after
    their `=' sign in order to be used in the manner of partial music
    functions.

    Also contains commits:

    Add/import music functions Syntax::property-{override,set)-function

    Syntax::property_operation -> Syntax::property_{override,revert,set,unset}

    No point in joining and later splitting separate functions.  The
    original motivation might have been to reduce name space pollution, but
    (scm ly-syntax-constructors) is a separate module by now.

    http://codereview.appspot.com/255340043

    Labels: -Patch-needs_work Patch-new

     

    Related

    Issues: #4505

  • Google Importer

    Google Importer - 2015-07-21

    Originally posted by: pkx1...@gmail.com

    Passes make, make check and a full make doc.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2015-07-24

    Originally posted by: pkx1...@gmail.com

    Patch on countdown for July 27th

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2015-07-27

    Originally posted by: pkx1...@gmail.com

    Patch counted down, please push.

    Labels: -Patch-countdown Patch-push

     
  • Google Importer

    Google Importer - 2015-07-27

    Originally posted by: dak@gnu.org

    Pushed to staging as
    commit [r66714074fd18d3483371c91441bf3f7df6a4cfb2]
    Author: David Kastrup <dak@gnu.org>
    Date:   Sun Jul 12 18:16:58 2015 +0200

        Issue 4505: Add partial \override and \set commands
       
        This allows \set and \override commands to be stopped short after
        their `=' sign in order to be used in the manner of partial music
        functions.

    commit [r099c754c4fed2f2df70d49b88a028fb39272d165]
    Author: David Kastrup <dak@gnu.org>
    Date:   Tue Jul 21 17:31:48 2015 +0200

        Add/import music functions Syntax::property-{override,set)-function

    commit [rd5a48e801bd400e47de34cdeb398fba3510d6940]
    Author: David Kastrup <dak@gnu.org>
    Date:   Tue Jul 21 17:11:18 2015 +0200

        Syntax::property_operation -> Syntax::property_{override,revert,set,unset}
       
        No point in joining and later splitting separate functions.  The
        original motivation might have been to reduce name space pollution, but
        (scm ly-syntax-constructors) is a separate module by now.

    Labels: -Patch-push Fixed_2_19_25
    Status: Fixed

     

    Related

    Issues: #4505

  • Colin Campbell

    Colin Campbell - 2015-09-03
    • Description has changed:

    Diff:

    
    
    • status: Fixed --> Verified
    • Needs: -->
    • Patch: -->
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.