Menu

#4488 Add ly:set-origin! for setting music origins

Verified
nobody
Maintainability
2015-07-30
2015-07-10
Anonymous
No

Originally created by: *anonymous

Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org

Add ly:set-origin! for setting music origins

Also gives ly:music-deep-copy an optional origin argument.

Also contains commit:

Use ly:set-origin! and two-argument form of ly:music-deep-copy

http://codereview.appspot.com/247690043

Related

Issues: #4505

Discussion

  • Google Importer

    Google Importer - 2015-07-10

    Originally posted by: dak@gnu.org

    Passes normal testing.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2015-07-10

    Originally posted by: pkx1...@gmail.com

    Fails make doc.

    --snip--
    Please check the logfile notation.bigtexi.log for errors

    make[2]: *** [out-www/notation-big-page.html] Error 255
    make[2]: *** Waiting for unfinished jobs....

    Please check the logfile internals.bigtexi.log for errors

    make[2]: *** [out-www/internals-big-page.html] Error 255

    Please check the logfile internals.splittexi.log for errors

    make[2]: *** [out-www/internals/index.html] Error 255

    Please check the logfile notation.splittexi.log for errors

    make[2]: *** [out-www/notation/index.html] Error 255
    make[2]: Leaving directory `/home/jlowe/lilypond-git/build/Documentation'
    make[1]: *** [WWW-2] Error 2
    make[1]: Leaving directory `/home/jlowe/lilypond-git/build'
    make: *** [doc] Error 2

    --snip--

    The various *texi.log files show the same thing:

    e.g.

    more Documentation/notation.bigtexi.log:

    ** Unknown command `@code' (left as is) (in out-www/scheme-functions.texi l. 136
    5)
    *** '{' without macro. Before: '()} in which case no action is performed.  The r
    eturn value is @var{m} itself. (in out-www/scheme-functions.texi l. 1365)
    Max error number exceeded

    Labels: -Patch-review Patch-needs_work

     
  • Google Importer

    Google Importer - 2015-07-10

    Originally posted by: dak@gnu.org

    Weird.  I'd have thought that plain "make" generates a version of the docs without images and that should include the doc strings.

    However, it would appear that the problem is @code {'()} instead of @code{'()} and maybe not all Texinfo backends are equally obnoxious about additional spaces.

    Will upload another version promptly.

     
  • Google Importer

    Google Importer - 2015-07-10

    Originally posted by: dak@gnu.org

    Fix doc string problem

    http://codereview.appspot.com/247690043

    Labels: -Patch-needs_work Patch-new

     
  • Google Importer

    Google Importer - 2015-07-10

    Originally posted by: pkx1...@gmail.com

    Passes make, make check and a full make doc

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2015-07-13

    Originally posted by: pkx1...@gmail.com

    Patch on countdown for July 18th

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2015-07-17

    Originally posted by: pkx1...@gmail.com

    Patch counted down - please push

    Labels: -Patch-countdown Patch-push

     
  • Google Importer

    Google Importer - 2015-07-17

    Originally posted by: dak@gnu.org

    Pushed to staging as
    commit [rf97e0fe119c56ade70262d227b5d05ee83391785]
    Author: David Kastrup <dak@gnu.org>
    Date:   Fri Jul 10 11:00:36 2015 +0200

        Issue 4488/2: Use ly:set-origin! and two-argument form of ly:music-deep-copy

    commit [r75b6979fb22f371780cefb6738b9ca56f1902b73]
    Author: David Kastrup <dak@gnu.org>
    Date:   Fri Jul 10 01:35:25 2015 +0200

        Issue 4488/1: Add ly:set-origin! for setting music origins
       
        Also gives ly:music-deep-copy an optional origin argument.

    Labels: -Patch-push Fixed_2_19_24
    Status: Fixed

     
  • Google Importer

    Google Importer - 2015-07-30

    Originally posted by: fedel...@gmail.com

    (No comment was entered for this change.)

    Status: Verified

     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.