#4452 Patch: Two reorganizations of ChordNames context

[Anonymous]

Originally created by: *anonymous

Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org

Two reorganizations of ChordNames context

Add Staff alias to ChordNames context

That way, Staff-level overrides like \key, \transposition and others
arrive in the ChordNames context.

Remove ChordNameVoice as a separate \midi context

http://codereview.appspot.com/243380043

[Google Importer]

Originally posted by: dak@gnu.org

(No comment was entered for this change.)

Owner: dak@gnu.org

[Google Importer]

Originally posted by: dak@gnu.org

Patchy the autobot says: Uh oh.  Regtests chord-changes.ly and chords-funky-ignatzek.ly fail for perfectly obvious reasons (both use << \context ChordNames ... \context Staff ... >>).  But I guess that there is not much more to do than replace \context with \new here and hope that not too much code of that kind is in the wild.

Labels: -Patch-new Patch-needs_work

[Google Importer]

Originally posted by: dak@gnu.org

Fix parallel uses of ChordNames with \context Staff

http://codereview.appspot.com/243380043

Labels: -Patch-needs_work Patch-new

[Google Importer]

Originally posted by: dak@gnu.org

Patchy the autobot says: passes tests.

Labels: -Patch-new Patch-review

[Google Importer]

Originally posted by: pkx1...@gmail.com

Patch on countdown for June 20th

Labels: -Patch-review Patch-countdown

[Google Importer]

Originally posted by: pkx1...@gmail.com

Patch counted down - please push

Labels: -Patch-countdown Patch-push

[Google Importer]

Originally posted by: dak@gnu.org

Pushed to staging as
commit [r1802fa3389d1a74364f7c17a3052b04ffcab364d]
Author: David Kastrup <dak@gnu.org>
Date:   Mon Jun 15 18:08:33 2015 +0200

    Issue 4452/3: Add Staff alias to ChordNames context
   
    That way, Staff-level overrides like \key, \transposition and others
    arrive in the ChordNames context.

commit [rea6199771a7e78b35bd651f7db5f1b9b8205ee22]
Author: David Kastrup <dak@gnu.org>
Date:   Mon Jun 15 19:37:01 2015 +0200

    Run scripts/auxiliar/makelsr.py

commit [rfa9d87071c06d7bd6894e3115d24a7eab725d924]
Author: David Kastrup <dak@gnu.org>
Date:   Mon Jun 15 19:34:37 2015 +0200

    Issue 4452/2: Fix uses of \context Staff alongside ChordNames context

commit [r4e44616a79529d2b2da85057a1cb2c225b968feb]
Author: David Kastrup <dak@gnu.org>
Date:   Mon Jun 15 18:06:41 2015 +0200

    Issue 4452/1: Remove ChordNameVoice as a separate \midi context

Labels: -Patch-push Fixed_2_19_22
Status: Fixed

[Google Importer]

Originally posted by: fedel...@gmail.com

(No comment was entered for this change.)

Status: Verified