Menu

#4443 Don't pass current parser/location into #{...#} call

Verified
nobody
Maintainability
2015-07-07
2015-06-12
Anonymous
No

Originally created by: *anonymous

Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org

Don't pass current parser/location into #{...#} call

The construct #{...#} generates a call to a function embedded-lilypond.
After issue 4422, this call passed (*parser*)/(*location*) arguments
instead of the previous parser/location arguments needed for accessing
the respective values in a different lexical environment.  But since the
respective values are stored in GUILE fluids rather than in lexical
variables now, they are already passed implicitly and unnecessary as
function parameters.

https://codereview.appspot.com/246940043/

Related

Issues: #4422
Issues: #4443

Discussion

  • Google Importer

    Google Importer - 2015-06-12

    Originally posted by: pkx1...@gmail.com

    Passes make, make check and a full make doc

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2015-06-14

    Originally posted by: pkx1...@gmail.com

    Patch on countdown for June 17th

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2015-06-16

    Originally posted by: pkx1...@gmail.com

    Patch counted down - please push

    Labels: -Patch-countdown Patch-push

     
  • Google Importer

    Google Importer - 2015-06-16

    Originally posted by: dak@gnu.org

    Pushed to staging as
    commit [r2fd5db04cdf6109e2c632337e13f29261df147b7]
    Author: David Kastrup <dak@gnu.org>
    Date:   Fri Jun 12 09:51:40 2015 +0200

        Issue 4443: Don't pass current parser/location into #{...#} call
       
        The construct #{...#} generates a call to a function embedded-lilypond.
        After issue 4422, this call passed (*parser*)/(*location*) arguments
        instead of the previous parser/location arguments needed for accessing
        the respective values in a different lexical environment.  But since the
        respective values are stored in GUILE fluids rather than in lexical
        variables now, they are already passed implicitly and unnecessary as
        function parameters.

    Labels: -Patch-push Fixed_2_19_22
    Status: Fixed

     

    Related

    Issues: #4422
    Issues: #4443

  • Google Importer

    Google Importer - 2015-07-07

    Originally posted by: fedel...@gmail.com

    (No comment was entered for this change.)

    Status: Verified

     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.