Menu
▾
▴
#4422 Obsolete parser/location arguments to music functions
Originally created by: *anonymous
Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org
This patch series is obviously related to issue 4421 as it makes the
latter issue quite more elegant to use, and there is no feasible way to
autoconvert issue 4421 to calling Scheme functions without
parser/location arguments. So this issue should come first.
Unfortunately, git cl/Rietveld currently have handed in their
resignation to me. No idea if anybody else would have more luck. So I
am putting this out for review in the classic manner, as formatted
patches. I'll put up a Google code issue presently but I'll not be able
to link it to a Rietveld issue as I am currently unable to create one.
Patch series can be viewed in mailing list archive at <URL:http://lists.gnu.org/archive/html/lilypond-devel/2015-05/msg00491.html>.
I am also pushing it to branch dev/dak/issue4422
Related
Issues: #2643
Issues: #4355
Issues: #4421
Issues: #4422
Issues: #4425
Issues: #4443
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Blocking: lilypond:4421
Originally posted by: dak@gnu.org
Make check looks fine with all combinations of running scripts/auxiliar/update-with-convert-ly.sh or not and fixing the jumbled location/parser argument pairs in some music functions or not. Looks backwards-compatible enough though I'll add a "make doc" run for good measure.
Labels: Patch-review
Originally posted by: dak@gnu.org
Man, this is like pulling teeth. Slowly figuring out how to make Rietveld happy, but git cl (and Patchy) is a different endeavor.
https://codereview.appspot.com/243800043
Originally posted by: pkx1...@gmail.com
Do you need me to test this?
Originally posted by: dak@gnu.org
No. I tested this one with quite more tests than normal but also including all normal tests. There are no new C++ constructs in it that could conceivably make a difference on a different test setup. I think this one is good to go.
Originally posted by: pkx1...@gmail.com
Patch on countdown for June 3rd
Labels: -Patch-review Patch-countdown
Originally posted by: dak@gnu.org
Oh great. Staging-patchy told me off. I, uh, had added some trivial further corrections before pushing. So I took a look at the error message and had a forehead-slap. I fixed this problem (music function calls already transfer location to 'origin, so it was just a matter of removing the unnecessary additional insertion of the no longer available "location" variable) and pushed again. Let's hope I did not have more easter eggs.
commit [r2f9328a294a9317af7fe91ebdb00534e0cba29ea]
Author: David Kastrup <dak@gnu.org>
Date: Wed May 27 17:05:34 2015 +0200
Issue 4422/7: Documentation fixes and Changelog
commit [rade3215602fec71d7a700f5093e1e4e75371c7f2]
Author: David Kastrup <dak@gnu.org>
Date: Sun May 31 20:37:14 2015 +0200
Issue 4422/6: Fix (define-music-function (parser ... uses in scm/
commit [r98ac53591234404cd70c5eebd370a598ec74095b]
Author: David Kastrup <dak@gnu.org>
Date: Wed May 27 04:25:32 2015 +0200
Issue 4422/5: Run scripts/auxiliar/update-with-convert-ly.sh
commit [r0200dabbc6e9bfa91c38f1199a2cdf9bfb43d026]
Author: David Kastrup <dak@gnu.org>
Date: Wed May 27 03:00:16 2015 +0200
Issue 4422/4: convert-ly rule for removing parser/location
commit [rc2539ac9d11b835d3b4560f60a36060f6e0a23d4]
Author: David Kastrup <dak@gnu.org>
Date: Wed May 27 01:35:08 2015 +0200
Issue 4422/3: Remove parser/location args from music function calls
When a music function definition starts with a parameter named "parser",
a compatibility definition is created that recreates the parameters
from the fluid accessors (*parser*) and (*location*) when necessary.
commit [r11990933427a4a166764ca800d54387523ac0355]
Author: David Kastrup <dak@gnu.org>
Date: Wed May 27 01:01:38 2015 +0200
Issue 4422/2: Fix various jumbled parser/location argument pairs
commit [r9a6b086e5af718384faa1395dcb1ea657724e616]
Author: David Kastrup <dak@gnu.org>
Date: Tue May 26 13:36:53 2015 +0200
Issue 4422/1: Remove parser/location global variable setup
Instead of relying on the global parser/location work horse (or
respective symbols in local scope), now fluids %parser/%location and
getter functions (*parser*)/(*location*) are employed for setting up the
general parsing and providing #{...#} with accurate information.
This patch removes the global setup and internal information flow: there
is still a variable "parser" being set in local parser modules.
Related
Issues:
#4422Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Blocking: -lilypond:4421
Originally posted by: fedel...@gmail.com
(No comment was entered for this change.)
Status: Verified