LilyIssues / Issues / #4409 Automatic fret diagrams should include barre indications when fingerings are given.

Google Importer - 2015-05-20

Originally posted by: Carl.D.S...@gmail.com

Sorry, I hit enter when I should have hit tab.

The code below:

{
\new FretBoards {
<f,-1 c-3 f-4 a-2 c'-1 f'-1>
}
}

produces a fretboard without a barre indicator, as shown in the first fret diagram. It would be nice to have the barre indicator added, as shown in the second.

Thanks to Patrick Schmidt for noticing this behavior.

Labels: Type-Enhancement

auto-barre-example.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-21

Originally posted by: fedel...@gmail.com

link to the discussion and suggested workarounds:
http://lists.gnu.org/archive/html/lilypond-user/2015-05/msg00550.html

in particular:
http://lists.gnu.org/archive/html/lilypond-user/2015-05/msg00566.html

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-21

Originally posted by: Carl.D.S...@gmail.com

Fix issue 4409 -- Add barre indicators to automatic fretboards

http://codereview.appspot.com/240080043

Labels: Patch-new
Owner: Carl.D.S...@gmail.com
Status: Started

Related

Issues: ~~#4409~~

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-22

Originally posted by: dak@gnu.org

Patchy the autobot says: passes tests.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-25

Originally posted by: pkx1...@gmail.com

Patch on countdown for May 28th

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-05-25

Originally posted by: Carl.D.S...@gmail.com

Discussion with Patrick Schmidt on -user has identified some changes that need to be made in the patch.

A new version will be uploaded shortly.

Labels: -Patch-countdown Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-06-08

Originally posted by: Carl.D.S...@gmail.com

A new version has bee added to the Rietveld issue. Patrick has already tested it. Other testers are welcome.

https://codereview.appspot.com/240080043/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-06-08

Originally posted by: Carl.D.S...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-06-09

Originally posted by: pkx1...@gmail.com

Passes make, make check and a full make doc.

Reg tests show:

--snip--

2.000000

input/regression/tablature-chord-repetition-finger.log

@@ -2,6 +2,10 @@
Parsing...
Renaming input to: `/home/james/lilypond-git/input/regression/tablature-chord-repetition-finger.ly'
Interpreting music...
+warning: Open fret on string 2 has finger of #f
+warning: Open fret on string 2 has finger of #f
+warning: Open fret on string 2 has finger of #f
+warning: Open fret on string 2 has finger of #f
Preprocessing graphical objects...
Calculating line breaks...
Drawing systems...

input/regression/tablature-chord-repetition-finger.log
1.000000

input/regression/tablature-zero-finger.log

@@ -2,6 +2,7 @@
Parsing...
Renaming input to: `/home/james/lilypond-git/input/regression/tablature-zero-finger.ly'
Interpreting music...
+warning: Open fret on string 4 has finger of #f
Preprocessing graphical objects...
Calculating line breaks...
Drawing systems...

input/regression/tablature-zero-finger.log

--snip--

James

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-06-09

Originally posted by: pkx1...@gmail.com

Let me retest this again. I didn't notice a new snippet.

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-06-09

Originally posted by: pkx1...@gmail.com

Fails make doc with this snippet

If you run Lilypond-book on a simple texi file using this snippet you get

you get

--snip--
GNU LilyPond 2.19.22
Processing `./snippet-map--4538054209664360919.ly'
Parsing...
Processing `./6d/lily-217a9ba6.ly'
Parsing...
././6d/lily-217a9ba6.ly:4:1: error: unrecognized string, not in text script or \lyricmode

unfingeredF = fingeredF =
././6d/lily-217a9ba6.ly:4:13: error: syntax error, unexpected '='
unfingeredF
= fingeredF =
././6d/lily-217a9ba6.ly:4:15: error: unrecognized string, not in text script or \lyricmode
unfingeredF =
fingeredF =
././6d/lily-217a9ba6.ly:-4:1: error: errors found, ignoring music expression

\relative c'
fatal error: failed files: "6d/lily-217a9ba6.ly"
command failed: /home/james/lilypond-git/build/out/bin/lilypond --formats=ps,png -dbackend=eps -I "./" --formats=eps -deps-box-padding=3.000000 -dread-file-list -dno-strip-output-dir "/home/james/Dropbox/Lilypond-patches/snippet-names--4538054209664360919.ly"
Child returned 1

--snip--

Which matches the same error as when building doc

It maybe expected or something to do with the @lilypond[..] variables used by the snippet docs. I cannot tell.

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-06-09

Originally posted by: dak@gnu.org

LilyPond does not offer multiple assignments.

The error would be in

Documentation/snippets/new/automatic-fretboards-barre.ly

Instead one has to do
unfingeredF = ...
fingeredF = #unfingeredF

But the regtest looks utterly unfinished anyway.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-06-09

Originally posted by: Carl.D.S...@gmail.com

Something went wrong with my git push. I will investigate.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-06-09

Originally posted by: Carl.D.S...@gmail.com

A new patch has been uploaded.

https://codereview.appspot.com/240080043/

This should fix both the added warnings and the bad regtest.

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-06-09

Originally posted by: pkx1...@gmail.com

Passes make, make check and a full make doc now but I still get the reg test warnings

--snip-

input/regression/tablature-chord-repetition-finger.log

@@ -2,6 +2,10 @@
Parsing...
Renaming input to: `/home/james/lilypond-git/input/regression/tablature-chord-repetition-finger.ly'
Interpreting music...
+warning: Open fret on string 2 has finger of #f
+warning: Open fret on string 2 has finger of #f
+warning: Open fret on string 2 has finger of #f
+warning: Open fret on string 2 has finger of #f
Preprocessing graphical objects...
Calculating line breaks...
Drawing systems...

input/regression/tablature-chord-repetition-finger.log
1.000000

input/regression/tablature-zero-finger.log

@@ -2,6 +2,7 @@
Parsing...
Renaming input to: `/home/james/lilypond-git/input/regression/tablature-zero-finger.ly'
Interpreting music...
+warning: Open fret on string 4 has finger of #f
Preprocessing graphical objects...
Calculating line breaks...
Drawing systems...

input/regression/tablature-zero-finger.log

--snip--

James

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-06-09

Originally posted by: Carl.D.S...@gmail.com

Hmm. I will investigate more. I don't know why I wasn't seeing them.

Labels: -Patch-review Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trevor Daniels - 2016-01-04

Description has changed:

Diff:

status: Started --> Accepted

Needs: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trevor Daniels - 2016-01-04

There has been no progress on this issue for 6 months so resetting status to Accepted.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Carl Sorensen - 2016-05-13

Place barres on fret diagrams if they can be inferred

http://codereview.appspot.com/294570043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Carl Sorensen - 2018-04-30

status: Accepted --> Started

assigned_to: Carl Sorensen

Needs: -->

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Carl Sorensen - 2018-04-30

labels: --> Patch - new
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Carl Sorensen - 2018-04-30

labels: Patch - new --> Patch-new
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Description has changed:

Diff:

--- old
+++ new
@@ -1,12 +1,5 @@
 *Originally created by:* *anonymous

-*Originally created by:* [Carl.D.S...@gmail.com](http://code.google.com/u/108033970883937506300/)
 *Originally owned by:* [Carl.D.S...@gmail.com](http://code.google.com/u/108033970883937506300/)

-**Please DO NOT add issues directly to this tracker unless**
-**you are certain that they correspond to our preferred**
-**format.**
-
-**Please keep attachments as small as possible.&nbsp; Google has a very small**
-**limit on the total size of attachments in the tracker.&nbsp; If you need to post**
-a larger file \(&gt;50 kByte - really\) please use a link.
+http://codereview.appspot.com/294570043

Type: --> Enhancement

Anonymous - 2018-05-01

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2018-05-01

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Automatic fret diagrams should include barre indications when fingerings are given.

Issue Tracker for LilyPond

Searches

Help

#4409 Automatic fret diagrams should include barre indications when fingerings are given.

Related

Discussion

Related