Menu

#4396 Allow ambitus to appear after clef and key signature

Verified
Enhancement
2020-04-29
2015-05-16
Anonymous
No

Originally created by: *anonymous

Originally created by: PhilEHol...@googlemail.com

Simon Albrecht requested that the ambitus should be allowed to be placed after the clef and key signature, since its meaning depends on both.  Phil Holmes commented that the Oxford "Madrigals and Partsongs" does this, and JOED places it after the time signature.

http://codereview.appspot.com/348050043

1 Attachments

Related

Issues: #5520
Issues: #5948
Issues: #762

Discussion

  • Google Importer

    Google Importer - 2015-07-24

    Originally posted by: dak@gnu.org

    The main worry I have with that is accidentals.  The accidentals for the ambitus should not hold for the following notes, should they?  So for one thing I'd put the ambitus before the time signature, for another I think it would make sense to choose a distinctly smaller font size for the ambitus accidentals.

     
    • Simon Albrecht

      Simon Albrecht - 2015-09-28

      Of course the ambitus should be before the time signature, that’s exactly how I do it.

       
  • Google Importer

    Google Importer - 2015-07-24

    Originally posted by: PhilEHol...@googlemail.com

    A couple of scans to confirm that this is what is done in the Oxford Madrigals and Partsongs.

     
  • Malte Meyn

    Malte Meyn - 2018-12-12
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -3,3 +3,5 @@
     *Originally created by:* [PhilEHol...@googlemail.com](http://code.google.com/u/112417728497802969867/)
    
     Simon Albrecht requested that the ambitus should be allowed to be placed after the clef and key signature, since its meaning depends on both.  Phil Holmes commented that the Oxford "Madrigals and Partsongs" does this, and JOED places it after the time signature.
    +
    +http://codereview.appspot.com/348050043
    
    • assigned_to: Malte Meyn
    • Needs: -->
    • Type: -->
     
  • Anonymous

    Anonymous - 2018-12-13
    • Attachments has changed:

    Diff:

    --- old
    +++ new
    @@ -0,0 +1 @@
    +test-results_issue4396_12Dec.zip (476.7 kB; application/zip)
    
     
  • Anonymous

    Anonymous - 2018-12-13

    Passes make, make check and a full make doc - test results attached.

     
  • Anonymous

    Anonymous - 2018-12-15

    Patch on countdown for Dec 15th

     
  • Anonymous

    Anonymous - 2018-12-17

    Passes make, make check and a full make doc - test results attached.

     
  • Anonymous

    Anonymous - 2018-12-21
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2018-12-21

    Patch on countdown for Dec 24th

     
  • Anonymous

    Anonymous - 2018-12-24
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2018-12-24

    Patch counted down - please push.

     
  • Malte Meyn

    Malte Meyn - 2018-12-24
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: push -->
     
  • Malte Meyn

    Malte Meyn - 2018-12-24

    commit 82aae9ab840bbd34604c7cfae2a10627790822aa
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Sat Dec 15 17:09:23 2018 +0100

    Issue 4396/3: add regtest
    

    commit 499b36f5d3e9ce96667638fba9c277f9915b4bff
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Wed Dec 12 11:45:20 2018 +0100

    Issue 4396/2: add \ambitusAfter
    

    commit 65c5233bfb83cdd51634da654e1b571b4b80e7cb
    Author: Malte Meyn lilypond@maltemeyn.de
    Date: Wed Dec 12 11:32:28 2018 +0100

    Issue 4396/1: improve ambitus’s horizontal spacing
    
     
  • Malte Meyn

    Malte Meyn - 2019-07-12

    Related: [#5520]

     

    Related

    Issues: #5520

  • Federico Bruni

    Federico Bruni - 2020-04-29
    • status: Fixed --> Verified
     
  • Federico Bruni

    Federico Bruni - 2020-04-29

    I'll open a new issue to document this new function, as the example in the Changes manual is not enough.