Menu ▾ ▴

#4375 \compressFullBarRests should be renamed

Verified
Valentin Villenave
Fixed_2_21_0 (565)
push
2020-04-27
2015-05-06
Anonymous
No

https://codereview.appspot.com/553750044

Originally created by: *anonymous

Originally created by: tdanielsmusic

Issue 3687 installed the music function \compressMMRests and replaced \compressFullBarRests and \expandFullBarRests with it in docs, snippets and regression test.  When this has bedded down we should:

1. Rename \compressFullBarRests and \expandFullBarRests to \compressEmptyMeasures and \expandEmptyMeasures, which more accurately express what setting skipBars actually does, together with a convert-ly entry to cover this change.

2. Modify the use of skipBars in Ancient music to use \compressEmptyMeasures and \expandEmptyMeasures instead.

Trevor

Related

Issues: #1291
Issues: #3687

Discussion

  • Google Importer

    Google Importer - 2015-05-12

    Originally posted by: tdanielsmusic

    (No comment was entered for this change.)

    Labels: Type-Defect

     

  • Valentin Villenave

    Valentin Villenave - 2020-03-21

    \compressFullBarRests should be renamed

    • Rename \compressFullBarRests to \compressEmptyMeasures
      as suggested by Trevor in #4375.

    • Document the new command (and explain its difference
      with \compressMMRests) by creating a new subsubsec in
      NR 1.6.3 "Writing parts".

    • Add index entries and links everywhere I can think of,
      obviously starting with NR 1.2.2.3 "Full measure rests".

    • Add convert rule and update syntax through the doc.

    • Clarify the (in)famous progerror
      "Multi_measure_rest::get_rods (): I am not spanned!"
      since a) the function it refers to has changed anyway
      b) its wording’s never been particularly helpful IMO.

    • This patch will require po-update and makelsr at
      some point (and snippets/new should be checked for
      duplicate stuff now that the LSR’s been updated).

    https://codereview.appspot.com/553750044

     

  • Anonymous

    Anonymous - 2020-03-22
    • Description has changed:

    Diff:
    • assigned_to: Valentin Villenave
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     

  • Anonymous

    Anonymous - 2020-03-22

    Passes make, make check and a full make doc.

     

  • Anonymous

    Anonymous - 2020-03-23
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,3 +1,5 @@
+https://codereview.appspot.com/553750044
+
 *Originally created by:* *anonymous

 *Originally created by:* [tdanielsmusic](http://code.google.com/u/tdanielsmusic/)
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2020-03-23

    Patch on countdown for March 25th - there are some nits on Rietveld though that need looking at.

     

  • Valentin Villenave

    Valentin Villenave - 2020-03-25
    • labels: --> Fixed_2_21_0
    • status: Started --> Fixed
    • Patch: countdown --> push
     

  • Federico Bruni

    Federico Bruni - 2020-04-27
    • status: Fixed --> Verified
     

  • Federico Bruni

    Federico Bruni - 2020-04-27

    Correct commit id on master:
    68fb45e7e20071b10c43f2a6f64681d56122e67d