LilyIssues / Issues / #4362 Completion_heads_engraver and dotted breve

#4362 Completion_heads_engraver and dotted breve

Status: Fixed

Owner: Malte Meyn

Labels: Fixed_2_21_0 (565)

Needs:

Patch:

Type: Enhancement

Updated: 2019-07-12

Created: 2015-05-01

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: RalphBug...@gmail.com

Simon Albrecht wrote :
Completion_heads_engraver doesn’t use dotted breve notes for its output, where smaller note values work as expected.

https://codereview.appspot.com/560810043

2 Attachments

completion-heads-dotted-breve.ly

completion-heads-dotted-breve.pdf

Discussion

Malte Meyn - 2019-07-07

Description has changed:

Diff:

status: Accepted --> Started

assigned_to: Malte Meyn

Needs: -->

Patch: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2019-07-07

Description has changed:

Diff:

--- old +++ new @@ -4,3 +4,5 @@ Simon Albrecht wrote : Completion\_heads\_engraver doesn’t use dotted breve notes for its output, where smaller note values work as expected. + +https://codereview.appspot.com/560810043

Needs: -->

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-07-07

Patch: new --> review

Type: --> Enhancement
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-07-07

Passes make, make check and a full make doc.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-07-09

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-07-09

Patch on countdown for July 11th

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-07-11

Patch: countdown --> push
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2019-07-11

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2019-07-12

labels: --> Fixed_2_21_0

status: Started --> Fixed

Patch: push -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Malte Meyn - 2019-07-12

commit 49f41bf1c64ae1e2490571e73a85cbc4b2a9fb27
Author: Malte Meyn lilypond@maltemeyn.de
Date: Sun Jul 7 18:07:58 2019 +0200

Issue 4362/2: add regtest

commit 17d3d3a1515e74f5aaa7f62604994cfdc1391361
Author: Malte Meyn lilypond@maltemeyn.de
Date: Sun Jul 7 12:55:19 2019 +0200

Issue 4362/1: head completion uses dotted breves Completion_heads_engraver and Completion_rest_engraver now use dotted breves, longas and maximas in the same way they use shorter dotted durations.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: