Menu
▾
▴
#4358 Patch: Set DynamicLineSpanner direction in \partcombine
Originally created by: *anonymous
Originally created by: nine.fie...@gmail.com
Originally owned by: nine.fie...@gmail.com
...
Originally posted by: nine.fie...@gmail.com
(No comment was entered for this change.)
Owner: nine.fie...@gmail.com
Originally posted by: nine.fie...@gmail.com
Add DynamicLineSpanner to the set of grobs whose direction is controlled by \voiceOne etc. This reverses a difference in the regression test part-combine-force.ly shown in Issue 4348.
Summary: Patch: Set direction of DynamicLineSpanner in \voiceOne etc.
Originally posted by: pkx1...@gmail.com
passes make, make check and a full make doc. Reg test diffs attached
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
I don't think that this is a good idea. Dynamics more often than not are for the whole Staff (and indeed that's the Midi default I believe). It is rather rare that separate voices have separate dynamics, and more often than not one will enter common dynamics in the first (namely upper) voice.
Originally posted by: nine.fie...@gmail.com
Then I'll restore the direction settings to \partcombine only.
Summary: Patch: Set DynamicLineSpanner direction in \partcombine
Labels: -Patch-review Patch-needs_work
Originally posted by: nine.fie...@gmail.com
change \partcombine only
http://codereview.appspot.com/237740043
Labels: -Patch-needs_work Patch-new
Originally posted by: pkx1...@gmail.com
Passes make, make check and a full make doc.
Reg test diff attached
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on countdown for May 3rd
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1...@gmail.com
Patch counted down - please push
Labels: -Patch-countdown Patch-push
Originally posted by: nine.fie...@gmail.com
Pushed to staging:
commit [r638ccfde1bf3069ab320beacbb734bed1494f3fa]
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date: Tue Apr 28 19:59:44 2015 -0400
Issue 4358: Set DynamicLineSpanner direction for \partcombine.
This reverses a difference in the regression test
part-combine-force.ly shown in Issue 4348.
Labels: -Type-Enhancement -Patch-push Type-Defect Fixed_2_19_20
Status: Fixed
Originally posted by: PhilEHol...@googlemail.com
Verified commit present in git
Status: Verified