#4350 \compressFullBarRests and \skipBars need a health warning

[Anonymous]

Originally created by: *anonymous

Originally created by: tdanielsmusic
Originally owned by: tdanielsmusic

The \compressFullBarRests predef, which simply sets skipBars true, can generate incorrectly set music if used carelessly.  The problem is that its action is not restricted to rests: it removes bar lines whenever a note crosses a bar line.  Notes crossing bar lines is common when setting renaissance music in a (semi)modern style with bar lines, or when a note of a tuplet crosses a bar line.  Both occurrences are shown in this example from Mark Koop:
(see http://lists.gnu.org/archive/html/lilypond-devel/2015-03/msg00212.html)

\version "2.19.18"

{
  \time 2/4
  [r4] c'2 [r4]
  [r4] \tuplet 3/2 { c'2 d'4 } [r4]
 
  \set Score.skipBars = ##t
  [r4] c'2 [r4]
  [r4] \tuplet 3/2 { c'2 d'4 } [r4]
}

My view is that \skipBars is working as designed, and its action on notes can be useful.  See for example its use in ancient music in the NR.  A better way of compressing full bar rests, restricted to that purpose, would be the best solution, but until then a warning or explanation about its wider effect is needed.

Trevor

[Google Importer]

Originally posted by: tdanielsmusic

Doc Issue 4350: \compressFullBarRests needs a warning

  The \compressFullBarRests predef, which simply sets
  skipBars true, can generate incorrectly set music if
  used carelessly.  The problem is that its action is
  not restricted to rests: it removes bar lines whenever
  a rest or a _note_ crosses a bar line.

  Add a warning to the NR and point to it from the LM.

  Use \compressFullBarRests in the LM example rather than
  explicitly setting skipBars, and show how the rests
  should be bracketed between \compressFullBarRests and
  \expandFullBarRests.

http://codereview.appspot.com/227470043

Labels: Patch-new
Status: Started

[Google Importer]

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes tests.  Includes a full make doc

Labels: -Patch-new Patch-review

[Google Importer]

Originally posted by: pkx1...@gmail.com

Patch on countdown for April 27th

Labels: -Patch-review Patch-countdown

[Google Importer]

Originally posted by: pkx1...@gmail.com

Patch counted down - please push

Labels: -Patch-countdown Patch-push

[Google Importer]

Originally posted by: tdanielsmusic

I'm not going to push this right away, as I may have a better solution shortly.  See Issue 3687.  For now I'll just leave it as Patch-push.

[Google Importer]

Originally posted by: pkx1...@gmail.com

Keeping on Push

[Google Importer]

Originally posted by: pkx1...@gmail.com

Keeping on Push

[Google Importer]

Originally posted by: pkx1...@gmail.com

Keeping on Push

[Google Importer]

Originally posted by: tdanielsmusic

This issue was superseded and fixed by the patch to Issue 3687, so marking the patch abandoned and the issue Fixed.

Labels: -Patch-push Patch-abandoned Fixed_2_19_20
Status: Fixed

[Google Importer]

Originally posted by: PhilEHol...@googlemail.com

(No comment was entered for this change.)

Status: Verified

[Anonymous]

.