Menu
▾
▴
#4344 Rewrite chordnames - disentangle data from formatting
Originally created by: *anonymous
Originally created by: thomasmo...@gmail.com
Originally owned by: thomasmo...@gmail.com
Considering thoughts from this discussion on -user
http://lilypond.1069038.n5.nabble.com/Typesetting-chord-symbols-td169855.html
data and formatting shouldn't be merged, as it is the current state.
Related
Discussion
Originally posted by: thomasmo...@gmail.com
Rewrite chordnames - disentangle data from formatting
Issue 4344
Store all data to print a chordmarkup in an alist.
Provide formatter for the elements of a chord and a final formatter
outputting the result.
Rename some rewritten procedures from scm/chord-name.scm reflecting
the new behaviour. With the need to change those names in
ly/engraver-init.ly and ly/property-init.ly as well.
The old 'alteration->text-accidental-markup' was used for bass-figures in
scm/translation-functions.scm. Thus inserted there.
scm/chord-generic-names.scm is fixed only so far that it does compile.
For a full test uncomment the section with the Banter-style in
/Documentation/included/chord-names-jazz.ly
http://codereview.appspot.com/223420043
Labels: Patch-new
Status: Started
Related
Issues: #4344
Originally posted by: thomasmo...@gmail.com
Fix tabs
http://codereview.appspot.com/223420043
Originally posted by: pkx1...@gmail.com
Passes make, make check and a full make doc.
Reg test diff attached
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-new
Originally posted by: pkx1...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
(No comment was entered for this change.)
Labels: -Patch-review Patch-needs_work
Originally posted by: thomasmo...@gmail.com
deeper disentangle, fixing TODOs
http://codereview.appspot.com/223420043
Labels: -Patch-needs_work Patch-new
Originally posted by: pkx1...@gmail.com
Passes make, make check and a full make doc.
Reg test diffs attached
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on countdown for May 3rd
Labels: -Patch-review Patch-countdown
Originally posted by: thomasmo...@gmail.com
Thanks James for testing.
The change in chords-funky-ignatzek.ly is intended, restoring a feature which got lost at the time we changed additionalPitchPrefix to "".
Nevertheless I stopped the countdown, changing label to needs-work.
Labels: -Patch-countdown Patch-needs_work
Can anyone see why this is 'new'? I cannot seem to find the change in the history but it has appeared on the 'patch new' list this morning.
pkx166h wrote Wednesday, October 21, 2015 9:36 AM
Subject: [testlilyissues:issues] #4344 Rewrite chordnames - disentangle data from formatting
Well, Thomas Morley posted the update shown in the attached email yesterday, but I don't know why this hasn't appeared as a post under the SourceForge issue itself.
Trevor
The "attached email" in my note above appears to have become detached. The essence of it was:
Related
Issues: #4344
No issue exits for http://codereview.appspot.com/268590043
Diff: