Better message for "too many clashing notecolumns" and better output in that case

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#4255 Better message for "too many clashing notecolumns" and better output in that case

Status: Verified

Owner: nobody

Labels: Fixed_2_19_15 (19)

Needs:

Patch:

Type: Documentation

Updated: 2015-03-01

Created: 2015-01-10

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: k-ohara5...@oco.net
Originally owned by: k-ohara5...@oco.net

Issue 3324 documented what "too many clashing notecolumns" means, which makes it clear that we can write a better error message.

Also, LilyPond can arbitrarily pick a voice to move, after giving the warning, to give a more-readable output in this case. The examples from issue 3324 are attached.

http://codereview.appspot.com/195030043

1 Attachments

test.preview.png

Discussion

Google Importer - 2015-01-11

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes tests. Includes a full make doc

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-01-13

Originally posted by: pkx1...@gmail.com

Patch on countdown for Jan 16th

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-01-13

Originally posted by: nine.fie...@gmail.com

Clearly the patch is an improvement, so I don't intend for this comment to delay the countdown, but it would look even better if the voice were moved just a little more so that the heads of the lower voice are not touching the stems of the upper.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-01-16

Originally posted by: pkx1...@gmail.com

Patch counted down - please push (also see comment #3)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-01-16

Originally posted by: pkx1...@gmail.com

(No comment was entered for this change.)

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-01-17

Originally posted by: k-ohara5...@oco.net

On #3, yes, there probably should be a bit of a gap.
I removed the overlap with the stem for issue 1774, but was not sure what engravers really do when voices cross. I'll find an example and open an issue.

Labels: -Patch-push Fixed_2_19_15
Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-01-17

Originally posted by: k-ohara5...@oco.net

The bug report from issue 3324 should give
warning This voice needs a \voiceXx setting
and the image of comment #1

\new PianoStaff <<
\new Staff = "up" { { f''8 e''8 e'' e'' } }
\new Staff = "down" { { e'8 \change Staff = "up" g'8 g' g' } } >>

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-03-01

Originally posted by: fedel...@gmail.com

commit [rc980af5e4f43a56ed9bf7a697858cd151fb92472]
Author: Keith OHara <k-ohara5a5a@oco.net>
Date:   Sat Jan 10 22:36:07 2015 -0800

    warning message for unspecified voicing; issue 4255

commit [r36bb1a592b0c33c466ffd4f5e7a05c8b5b225a28]
Author: Keith OHara <k-ohara5a5a@oco.net>
Date:   Sat Jan 10 22:36:07 2015 -0800

    resolve note-collisions in absence of explicit voicing; issue 4255

Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: