Patch: Remove Unfolded_repeat_iterator

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#4252 Patch: Remove Unfolded_repeat_iterator

Status: Verified

Owner: nobody

Labels: Fixed_2_19_16 (119)

Needs:

Patch:

Type: Enhancement

Updated: 2017-11-10

Created: 2015-01-08

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: nine.fie...@gmail.com
Originally owned by: nine.fie...@gmail.com

Remove Unfolded_repeat_iterator and rely on Sequential_iterator with a customized elements-callback factored out of unfold-repeats-fully.

http://codereview.appspot.com/194100043

Discussion

Google Importer - 2015-01-08

Originally posted by: nine.fie...@gmail.com

(No comment was entered for this change.)

Owner: nine.fie...@gmail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-01-09

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes tests. Includes a full make doc

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-01-11

Originally posted by: pkx1...@gmail.com

Patch on countdown for Jan 13th - note there are some comments on Rietveld to take care of.

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-01-11

Originally posted by: nine.fie...@gmail.com

The motivation for this patch is to eliminate redundant code.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-01-13

Originally posted by: pkx1...@gmail.com

Patch counted down - please push

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-01-13

Originally posted by: nine.fie...@gmail.com

commit [r1dbadfcf82a2cfb2a9cccada47faf449ddf896ed]
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Thu Jan 8 23:27:35 2015 -0500

    Issue 4252: Remove Unfolded_repeat_iterator

    To eliminate redundancy, remove Unfolded_repeat_iterator and rely on
    Sequential_iterator with a customized elements-callback factored out
    of unfold-repeats-fully.

Summary: Patch: Remove Unfolded_repeat_iterator
Labels: -Patch-push Fixed_2_19_16
Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2015-03-02

Originally posted by: fedel...@gmail.com

(No comment was entered for this change.)

Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Kastrup - 2017-11-10

I see "the motivation for this patch is to eliminate redundant code". I am currently trying to deal with fixing the Volta_repeat_iterator. Seminal features here are that its actions are relevant for all of the Timing context (not just the context the construct may appear in), and that every alternative starts with the same meter and current chord as the first alternative. It would appear that this isn't easily achieved outside of a specialized iterator, so the redundancy argument is likely a bit shaky concerning at least some of the semantics. It's not going to see a change for 2.20 but I am not clear about how to proceed here in the long run.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: