#4204 Patch: Convert ly::time-signature::print from C++ to Scheme.

[Anonymous]

Originally created by: *anonymous

Originally created by: nine.fie... (code.google.com)@gmail.com
Originally owned by: nine.fie... (code.google.com)@gmail.com

Convert ly::time-signature::print from C++ to Scheme.

The user may add a new time signature style by calling
add-simple-time-signature-style and providing a procedure returning
markup.

http://codereview.appspot.com/176180043

[Google Importer]

Originally posted by: nine.fie... (code.google.com)@gmail.com

(No comment was entered for this change.)

Owner: nine.fie...@gmail.com

[Google Importer]

Originally posted by: pkx1... (code.google.com)@gmail.com

Fails to apply to current master

Labels: -Patch-new Patch-needs_work

[Google Importer]

Originally posted by: nine.fie... (code.google.com)@gmail.com

Oh, that's because it depends on the patch in issue 4196.  I didn't want to include that code in the review for this issue.

[Google Importer]

Originally posted by: nine.fie... (code.google.com)@gmail.com

Rebase

http://codereview.appspot.com/176180043

Labels: -Patch-needs_work Patch-new

[Google Importer]

Originally posted by: pkx1... (code.google.com)@gmail.com

Patchy the autobot says: passes tests.  includes a full make doc

Labels: -Patch-new Patch-review

[Google Importer]

Originally posted by: pkx1... (code.google.com)@gmail.com

Patch on countdown for December 8th

Labels: -Patch-review Patch-countdown

[Google Importer]

Originally posted by: nine.fie... (code.google.com)@gmail.com

I'd feel irresponsible pushing this patch without any acknowledgment from a more experienced contributor.  Even something as simple as "based on the summary and the test results, I'm not worried" would suffice.  Thanks.

[Google Importer]

Originally posted by: pkx1... (code.google.com)@gmail.com

keith had some comments on Rietveld. I think you could make the change about just removing the regression test and still push this, but if you are uncertain change this back to countdown for the 11th, else please push.

Labels: -Patch-countdown Patch-push

[Google Importer]

Originally posted by: nine.fie... (code.google.com)@gmail.com

Pushed without the regression test.  Thanks for the review, Keith.

commit [r145389636e81237d560aba4d04abcb89fa60cd9c]
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Sun Nov 2 20:32:57 2014 -0500

Labels: -Patch-push Fixed_2_19_16
Status: Fixed

[Google Importer]

Originally posted by: PhilEHol...@googlemail.com

(No comment was entered for this change.)

Status: Verified