Menu
▾
▴
#4196 Patch: Add \compound-meter markup command
Originally created by: *anonymous
Originally created by: nine.fie... (code.google.com)@gmail.com
Originally owned by: nine.fie... (code.google.com)@gmail.com
Add \numbered-time-signature markup command
This command can produce compound, simple, and single-digit time signatures.
Discussion
Originally posted by: nine.fie... (code.google.com)@gmail.com
(No comment was entered for this change.)
Owner: nine.fie...@gmail.com
Originally posted by: pkx1... (code.google.com)@gmail.com
Patchy the autobot says: passes tests. Includes a full make doc
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
How about only making a \time-signature markup command? The style can just be taken from the "style" property. It should, in the case of typesetting a grob, be available from the standard grob property list (I think). Otherwise, it can be put there with \override.
Originally posted by: nine.fie... (code.google.com)@gmail.com
I think I should post a review of all my C++-to-scheme work to give you context. It won't be today, though, so I'll attempt to answer your question briefly.
> How about only making a \time-signature markup command? The style can just be taken from the "style" property.
That would amount to (1) use style as a key to look up a markup procedure and (2) call the procedure. This is what the time-signature print callback does in my branch. What I have posted here is the inner procedure that is called directly for the "numbered" style, wrapped in a very simple lambda for the "single-digit" style, or called from a slightly more complicated function for the "C" style when no glyph is found.
As I mentioned in the review, if you don't want to see \numbered-time-signature as a documented markup command, I'll be happy to convert it back to just a function that builds markup.
A generic \time-signature could be implemented if it were useful, but I don't think it's actually that useful, and the interface required for compound time signatures is an unnecessary complication for styles other than numbered.
Originally posted by: nine.fie... (code.google.com)@gmail.com
Rename to \compound-meter
http://codereview.appspot.com/173260043
Labels: -Patch-review Patch-new
Originally posted by: pkx1... (code.google.com)@gmail.com
Patchy the autobot says: passes tests. Inlcudes a full make doc
Labels: -Patch-new Patch-review
Originally posted by: pkx1... (code.google.com)@gmail.com
Patch on countdown for Nov 23rd (Do we need a tracker for documentation in the NR or other non-code file places?)
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1... (code.google.com)@gmail.com
Sorry, my mistake (too many Tabs open) This is back on Reivew... I skipped a step!
Labels: -Patch-countdown Patch-review
Originally posted by: nine.fie... (code.google.com)@gmail.com
The new command is listed with an example in the markup appendix of the NR. Something somewhere automates that.
Summary: Patch: Add \compound-meter markup command
Originally posted by: pkx1... (code.google.com)@gmail.com
Patch on countdown for Nov 26th
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1... (code.google.com)@gmail.com
Patch counted down please push.
Labels: -Patch-countdown Patch-push
Originally posted by: nine.fie... (code.google.com)@gmail.com
commit [r19938f57d5f3e34fe25be79108688fe47ad59a66]
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date: Sat Nov 15 09:55:34 2014 -0500
Labels: -Patch-push Fixed_2_19_16
Status: Fixed
Originally posted by: david.na... (code.google.com)@gmail.com
(No comment was entered for this change.)
Status: Verified