Menu
▾
▴
#4068 Patch: Add a convert-ly rule for xxx #'yyy #'zzz = -> xxx.yyy.zzz =
Originally created by: *anonymous
Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org
Add a convert-ly rule for xxx #'yyy #'zzz = -> xxx.yyy.zzz =
Alist assignments can also use symbol list syntax as of issue 3748.
So the examples for nested layout variable assignments should actually
use those.
Also contains commit:
Run scripts/auxiliar/update-with-convert-ly.sh
When pushed to staging, another commit reverting the convert-ly rule
will be added since we don't want to apply somewhat generic patterns
like those on unknown user-provided code when unchanged code remains
valid.
It turns out that this conversion applies to seriously erroneous
documentation in Documentation/notation/spacing.itely and translations
where normal assignments and overrides are getting confused. Fixing
that would be a separate issue.
Discussion
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Owner: dak@gnu.org
Originally posted by: dak@gnu.org
conversion rule is only temporarily, so converted imported snippets need to be retained explicitly
http://codereview.appspot.com/126350043
Originally posted by: dak@gnu.org
Rebase on current master
http://codereview.appspot.com/126350043
Originally posted by: pkx1...@gmail.com
Passes make, make check and a full make doc.
I note that the reg test
input/regression/harp-pedals.log
shows:
@@ -2,6 +2,8 @@
Renaming input to: `/tmp/lilypond-autobuild/input/regression/harp-pedals.ly'
Interpreting music...
Preprocessing graphical objects...
+error: Cyclic markup detected: line-markup
+warning: BarNumber has empty extent and non-empty stencil.
Calculating line breaks...
Drawing systems...
Writing header field `texidoc' to `/tmp/build-lilypond-autobuild/out/lybook-testdb/1b/lily-7ff580f2.texidoc'...
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
Good eye. It is extremely unlikely that this is causally related to this particular change. I suspect that the "cyclic markup" detection code is just broken (I remember looking at it some time or other and thinking "seriously?") and triggers sort of randomly. Do you have a "-error: Cyclic markup..." somewhere in your diffs? That would indicate that the warning moved from one place to another, based on the order of regtests.
Originally posted by: dak@gnu.org
Regarding comment #4: see issue 4070.
Originally posted by: pkx1...@gmail.com
To answer #5
"Do you have a "-error: Cyclic markup..." somewhere in your diffs?"
No. Only that one +error.
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Labels: -Type-Enhancement Type-Documentation
Originally posted by: pkx1...@gmail.com
Patch on countdown for August 24th
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1...@gmail.com
Patch counted down - please push
Labels: -Patch-countdown Patch-push
Originally posted by: dak@gnu.org
Pushed to staging as
commit [r8b88cefdbf71ba371e16bbe1b54ed1aa9f1871ce]
Author: David Kastrup <dak@gnu.org>
Date: Sun Aug 17 14:40:31 2014 +0200
Run scripts/auxiliar/makelsr.py
commit [r6145fa025e0bd5b822b1ff22dab69a251b624b2b]
Author: David Kastrup <dak@gnu.org>
Date: Sun Aug 17 14:40:07 2014 +0200
Copy some snippets converted with temporary rule to snippets/new
This avoids them being overwritten on next LSR import
commit [r7a249faa5b5c5225d3ff8f594096fcd4a873a6cc]
Author: David Kastrup <dak@gnu.org>
Date: Sun Aug 24 13:21:59 2014 +0200
Revert "Issue 4068: Add a convert-ly rule for xxx #'yyy #'zzz = -> xxx.yyy.zzz ="
This reverts commit [r7f34e80b8d8bebfa4b1f3721a12718b04d7e02f4].
commit [rff2ab19cbba5149e92584c6661a73ee63ccc45da]
Author: David Kastrup <dak@gnu.org>
Date: Sun Aug 17 10:41:00 2014 +0200
Run scripts/auxiliar/update-with-convert-ly.sh
commit [r7f34e80b8d8bebfa4b1f3721a12718b04d7e02f4]
Author: David Kastrup <dak@gnu.org>
Date: Sat Aug 16 23:24:21 2014 +0200
Issue 4068: Add a convert-ly rule for xxx #'yyy #'zzz = -> xxx.yyy.zzz =
Alist assignments can also use symbol list syntax as of issue 3748.
So the examples for nested layout variable assignments should actually
use those.
Labels: -Patch-push Fixed_2_19_13
Status: Fixed
Originally posted by: ColinPKC...@gmail.com
Traced all committishes into master.
Status: Verified