Menu

#4029 Patch: Remove warning when there are no noteheads to attach lyrics to.

Verified
nobody
Other
2014-08-12
2014-07-26
Anonymous
No

Originally created by: *anonymous

Originally created by: janek.li...@gmail.com
Originally owned by: janek.li...@gmail.com

Remove warning when there are no noteheads to attach lyrics to.

The warning was added to address issue 248, but it is now moot after
issue 3254 (c73b41b3e7be6d7): attaching lyrics to a note-less context
(like Devnull) is perfectly legal now.

http://codereview.appspot.com/120200043

Related

Issues: #4030

Discussion

  • Google Importer

    Google Importer - 2014-07-26

    Originally posted by: janek.li...@gmail.com

    (No comment was entered for this change.)

    Owner: janek.li...@gmail.com

     
  • Google Importer

    Google Importer - 2014-07-26

    Originally posted by: pkx1...@gmail.com

    Patchy the autobot says: passes tests.  Includes a full make doc

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2014-07-26

    Originally posted by: janek.li...@gmail.com

    I'll push this tomorrow morning if no one objects - I don't think we need full review for this.

     
  • Google Importer

    Google Importer - 2014-07-27

    Originally posted by: janek.li...@gmail.com

    Pushed as

    commit [r476687b992c1c0d551b0d425e5ece78c39cfc3ef]
    Author: Janek Warchoł <lemniskata.bernoullego@gmail.com>
    Date:   Sat Jul 26 09:00:39 2014 +0200

        Remove warning when there are no noteheads to attach lyrics to.
       
        The warning was added to address issue 248, but it is now moot after
        issue 3254 (c73b41b3e7be6d7): attaching lyrics to a note-less context
        (like Devnull) is perfectly legal now.

    Labels: -Type-Enhancement -Patch-review Type-Other Fixed_2_19_11
    Status: Fixed

     
  • Google Importer

    Google Importer - 2014-08-12

    Originally posted by: ColinPKC...@gmail.com

    (No comment was entered for this change.)

    Status: Verified