Menu
▾
▴
#3962 Patch: use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters
Verified
nobody
Defect
2014-08-09
2014-06-22
Anonymous
No
Originally created by: *anonymous
Originally created by: janek.li...@gmail.com
Originally owned by: janek.li...@gmail.com
use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters
It makes more sense to use X-parents than Y-parents for horizontal
alignment. To be able to do this, we have to ensure that X-parents of
MultiMeasureRestNumber, MultiMeasureRestText and PercentRepeatCounter
won't be overwritten by set_bound (these grobs are spanners). We can
do this because parents of these grobs are spanners as well.
Expected changes in output: none.
Discussion
Originally posted by: janek.li...@gmail.com
(No comment was entered for this change.)
Owner: janek.li...@gmail.com
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes make, make check and a full make docs.
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on countdown for June 29
Labels: -Patch-review Patch-countdown
Originally posted by: janek.li...@gmail.com
(No comment was entered for this change.)
Blocking: lilypond:3979
Originally posted by: pkx1...@gmail.com
Patch counted down - please push
Labels: -Patch-countdown Patch-push
Originally posted by: janek.li...@gmail.com
pushed as
commit [rf4d8c77fc2ebac49bbdb0d0e9bec636313508846]
Author: Janek Warchoł <lemniskata.bernoullego@gmail.com>
Date: Mon Apr 8 15:58:08 2013 +0200
use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters
It makes more sense to use X-parents than Y-parents for horizontal
alignment. To be able to do this, we have to ensure that X-parents of
MultiMeasureRestNumber, MultiMeasureRestText and PercentRepeatCounter
won't be overwritten by set_bound (these grobs are spanners). We can
do this because parents of these grobs are spanners as well.
Expected changes in output: none.
Labels: -Type-Enhancement -Patch-push Type-Defect Fixed_2_19_9
Status: Fixed
Originally posted by: dak@gnu.org
Well, it is a bit late to comment after this has been pushed. I feel uncertainty about "It makes more sense to use X-parents than Y-parents for horizontal alignment.".
The basic uncertainty boils down to the question: "what are the legitimate use cases for X-parent and Y-parent pointing to different items". I don't know the answer to that off-hand. If the answer is "none", then we could make do with just a single XY-parent, making it unnecessary to think about that particular question in future.
If the answer is different from "none", then looking at those use cases would tell us how to evaluate the "it makes more sense to use X-parents than Y-parents" statement which I currently don't feel qualified to judge.
Anybody have any insights or knowledge here?
Cc: k-ohara5...@oco.net
Originally posted by: janek.li...@gmail.com
For example lyrics:
<<
{ b a b g }
\addlyrics { la mib bo bo }
>>
With some debugging code added, i get
I'm a LyricText and my X-parent is NoteHead and my Y-parent is VerticalAxisGroup
I'm a LyricText and my X-parent is NoteHead and my Y-parent is VerticalAxisGroup
I'm a LyricText and my X-parent is NoteHead and my Y-parent is VerticalAxisGroup
I'm a LyricText and my X-parent is NoteHead and my Y-parent is VerticalAxisGroup
Makes sense to me - lyrics are horizontally aligned on the notes, but their vertical placement depends on other lyrics which are composed into a VerticalAxisGroup.
Originally posted by: dak@gnu.org
Yes, makes sense. Overall, this patch seems sane. Hopefully the original function was not already in use outside of LilyPond proper. It seems pretty obscure, though.
Originally posted by: janek.li...@gmail.com
:)
Do you think this information should be added somewhere? Maybe as a comment in self-alignment-interface?
Originally posted by: fedel...@gmail.com
(No comment was entered for this change.)
Status: Verified
Originally posted by: janek.li...@gmail.com
(No comment was entered for this change.)
Labels: Janek_alignment_changes