Patch: Issue 3916: Add \alternatingTimeSignatures

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#3918 Patch: Issue 3916: Add \alternatingTimeSignatures

Status: Accepted

Owner: nobody

Labels: None

Needs:

Patch: waiting

Type: Enhancement

Updated: 2015-10-29

Created: 2014-05-08

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: lilyli...@googlemail.com
Originally owned by: lilyli...@googlemail.com

Issue 3916: Add \alternatingTimeSignatures

A function to print a group of time signatures indicating a section
of music with (irregularly) changing meters.
Takes a list of lists, each sublist representing one time signature.
The first of the time signatures will be used to set the new effective
time signature, apart from that the function doesn't affect timing at all.

http://codereview.appspot.com/97110045

Related

Issues: ~~#3916~~

Discussion

Google Importer - 2014-05-08

Originally posted by: lilyli...@googlemail.com

(No comment was entered for this change.)

Owner: lilyli...@googlemail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-09

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: fails make - I haven't had time to find out why

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-09

Originally posted by: lilyli...@googlemail.com

It's definitely in the doc part. I just built it without the doc commit and it works.
I'll look into it.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-09

Originally posted by: lilyli...@googlemail.com

Fixing doc error

http://codereview.appspot.com/97110045

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-09

Originally posted by: pkx1...@gmail.com

It wasn't failing on 'make doc' it was failing on just 'make'.

I'll retest the patch anyhow.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-09

Originally posted by: lilyli...@googlemail.com

Hm.
I use Janek's script to build lily, so I'm not sure if it's actually running make or what.
But when I first built it, it gave a failure, but somewhere during some documentation files.
When I reset it to the commit before the doc addition it ran without problems and built lily with the added functionality.

We'll see what your test will revel ...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-09

Originally posted by: PhilEHol...@googlemail.com

Make does build some of the documentation and it's probably this causing patchy to fail. I'm guessing that Janek's scripts simply build the binary.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-09

Originally posted by: ulidesi...@googlemail.com

I've inspected Janek's script and it sais

make $MAKE_OPTIONS

so it uses make with some options it has gathered.
_But_ with my initial patch it failed to build here too.
When checking out the commit without the doc it built, and with my modified patch it also builds _with_ it.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-10

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make check and a full make docs.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-10

Originally posted by: lilyli...@googlemail.com

Doc needs rewording, as of http://lists.gnu.org/archive/html/lilypond-devel/2014-05/msg00064.html

Labels: -Patch-review Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-10

Originally posted by: lilyli...@googlemail.com

rewording doc section

http://codereview.appspot.com/97110045

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-10

Originally posted by: lilyli...@googlemail.com

rewording doc section, now correctly rebased

http://codereview.appspot.com/97110045

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-10

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make check and a full make docs.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-10

Originally posted by: lilyli...@googlemail.com

reword docs according to Trevor's suggestions

http://codereview.appspot.com/97110045

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-10

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make check and a full make docs.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-12

Originally posted by: lilyli...@googlemail.com

(No comment was entered for this change.)

Labels: -Patch-review Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-16

Originally posted by: lilyli...@googlemail.com

Change to \fractionList, add argument validation and the printing of hyphens

http://codereview.appspot.com/97110045

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-16

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make check and a full make docs.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-18

Originally posted by: pkx1...@gmail.com

I think this still needs work (can't tell for certain on the Reitveld thread) - else if not, then change the Label to Patch-countdown

Labels: -Patch-review Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2014-05-18

Originally posted by: lilyli...@googlemail.com

I can't tell either if the _current_ patch needs work. Anyway it should wait until the discussion it triggered is finished. Then we'll see if the patch should be changed, can be used as is or has become obsolete.

Labels: -Patch-needs_work Patch-waiting

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trevor Daniels - 2015-10-29

Description has changed:

Diff:

status: Started --> Accepted

Needs: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trevor Daniels - 2015-10-29

This patch seemed to be pretty well ready for pushing over 18 months ago, but discussion then ceased. Setting to Status:Accepted to allow someone else to pick it up.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: