Documentation for \offset is required

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#3830 Documentation for \offset is required

Status: Verified

Owner: David Nalesnik

Labels: Fixed_2_19_55 (28)

Needs:

Patch:

Type: Documentation

Updated: 2017-02-16

Created: 2014-01-29

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: tdanielsmusic

The \offset function introduced in 2.17.95 (see
Issue 3629 for details) merits full documentation.

Unfortunately it does not easily 'slot in' to any
existing section in either the LM or NR. Perhaps
the most obvious place for it is Section 4.6.1 in
the LM, "Moving Objects", but even here some
rearrangement of the existing text would be needed.
If it were to be added to the LM in this way, the
existing documentation in the NR (in A18 "Available
Music Functions") would just about suffice.

Related

Issues: ~~#3629~~

Discussion

David Nalesnik - 2017-01-23

Issue 3830: Document \offset command

http://codereview.appspot.com/319150043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-24

Description has changed:

Diff:

status: Accepted --> Started

assigned_to: David Nalesnik

Needs: -->

Type: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-24

Patch: new --> needs_work

Type: --> Documentation
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-01-24

Be more expansive

http://codereview.appspot.com/319150043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-01-25

Improve wording, add slashes

http://codereview.appspot.com/319150043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-01-25

Clarify criteria/examples

http://codereview.appspot.com/319150043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-01-25

diagram syntax, other improvements

http://codereview.appspot.com/319150043

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-01-26

Needs: -->

Type: --> Documentation
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-01-27

The last patchset is ready for testing. Do I need to change the "Patch" label to "review" to indicate that it's ready for testing or is that done after testing is done?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous - 2017-01-27
  
  Patch 'New' means it is on the list to test. I can see it on the list to 'test'. It will sit there until someone tests it full (make, make check, make doc)
  
  Unfortunately I seem to be the only one that fully tests patches at the moment - at least I am the most pro-active simply because I can while I am at work during the day.
  
  There's no technical reason someone else could not test patches other than you need to do a full make test-basline/make check comparison and make doc and those take time on laptops which is why (mostly) the other devs don't test patches fully I guess. I am lucky to have lots of cores on my work and home desktops.
  
  I haven't had a chance to test any patches the last couple of days with other commitments. Hence the reason it is still on the 'New' list.
  
  There is a countdown due today, which I will process this evening and if the patch is still there to test, I can do it then.
  
  Regards
  
  James
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-01-27

Patch: new --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-01-27

OK, thanks for the explanation. I guess I imagined that the process was automated through patchy.

I just ran make, make test-baseline/make check(1), and make doc. All passed.

(1) The only changes I get with make check are to input/regression/output-distance.ly

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-30

Patch: review --> countdown
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-01-30

Patch on countdown for Februray 2nd.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2017-02-02

Patch counted down - please push.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-02-02

labels: --> Fixed_2_19_55

status: Started --> Fixed

Patch: countdown -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Nalesnik - 2017-02-02

Pushed to staging as

commit 28720b35daafc5e1b39fe041cb7fde8d19eae95a
Author: David Nalesnik david.nalesnik@gmail.com
Date: Sat Jan 21 14:02:31 2017 -0600

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Federico Bruni - 2017-02-16

status: Fixed --> Verified
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: