Menu
▾
▴
1 Attachments
#3693 PercentRepeat no dots with odd time signatures, RhythmicStaff
Originally created by: *anonymous
Originally created by: ColinPKC...@gmail.com
Originally owned by: dak@gnu.org
Reported by Joram:
If I use a percent repeat in a customly timed measure (5/4 instead of
4/4), the repeat symbol lacks the dots and is placed to the left of the
bar. If I write something before the repeat (a time signature or only
<>), then the dots reappear and they are placed properly.
Thanks for clarification,
Joram
\version "2.16.2" % also tested with 2.17.26
<<
\new Staff {
\tempo "wrong?"
\time 5/4
\repeat unfold 10 a'4
}
\new RhythmicStaff {
\repeat percent 2 { c4 c c c c }
}
>>
<<
\new Staff {
\tempo "what I expect"
\time 5/4
\repeat unfold 10 a'4
}
\new RhythmicStaff {
<> % (*) this is the only difference
\repeat percent 2 { c4 c c c c }
}
>>
****************
Tested with 2.19.0 and reproduced error.
Also, the problem seems to be time signatures with odd numerators: 3/4 and 7/4 give the same error.
Originally posted by: dak@gnu.org
I think the problem is that Percent_repeat_iterator::get_music_list is called at a time where measure_length (get_outlet ()) has not yet seen the meter change. Perhaps one needs to move the decision making.
Originally posted by: ColinPKC...@gmail.com
Issue 3703 has been merged into this issue.
Originally posted by: simon.al...@mail.de
See also <http://lists.gnu.org/archive/html/lilypond-user/2015-07/msg00054.html>, namely a similar issue with changing time signature within the percent repeat music.
Originally posted by: pkx1...@gmail.com
Should we put in an @knownissue in an appropriate place in the notation reference?
Originally posted by: tdanielsmusic
Re #4: We don't normally add faults recorded in the Issues DB to the known issues (there are currently around 1000 of them), but occasionally we do so if devs agree a fix is pretty unlikely to be forthcoming, and there is a work-around. Issue 34 is a good example of one of the exceptions. I'm not sure this issue qualifies.
Known issues are really limitations of the current design and implementation, not bugs due to mistakes or bad coding. Actually, I guess Issue 34 _is_ a limitation of the current design, so it would qualify anyway.
Trevor
Labels: -Type-Ugly Type-Defect
Related
Issues: #34
Originally posted by: dak@gnu.org
Oops. My analysis in comment #1 does not fit the report. It does fit the problem reported in the mail mentioned in issue #3.
This issue here seems rather straightforward to fix. The one in issue #3 is much harder. It should get a different report.
Originally posted by: dak@gnu.org
Well... Seems like the problem will not readily yield to anything less than fixing comment #3. So we may as well keep this a single report.
Originally posted by: dak@gnu.org
Issue 3693: Let Percent_repeat_iterator be unfazed by Timing changes
There is still one shortcoming: the percent repeats will not contain any
material apart from the percent itself. In particular, no Timing
changes will be repeated. If there are meter changes or \partial
commands inside of percent repeats, they need to occur in parallel
passages outside of any percent repeat, if necessary in a separate
"timing track".
This particular shortcoming is worth illustrating in a @knownissue: I see no reasonably reliable way around repeating the timing info parallel to the percent repeats.
http://codereview.appspot.com/255240043
Labels: Patch-new
Owner: dak@gnu.org
Status: Started
Originally posted by: pkx1...@gmail.com
Passes make, make check and a full make doc.
I'll add a new issue for to make an @knownissue as per comment #8
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on countdown for July 21st
(PS. Tracker issue 4506 is for the @knownissues to be added)
Labels: -Patch-review Patch-countdown
Related
Issues:
#4506Originally posted by: pkx1...@gmail.com
Patch counted down - please push.
Labels: -Patch-countdown Patch-push
Originally posted by: dak@gnu.org
Pushed to staging as
commit [rb416f10429d8d3881445d9000ff422dc67176df1]
Author: David Kastrup <dak@gnu.org>
Date: Wed Jul 15 23:30:30 2015 +0200
Issue 3693: Let Percent_repeat_iterator be unfazed by Timing changes
There is still one shortcoming: the percent repeats will not contain any
material apart from the percent itself. In particular, no Timing
changes will be repeated. If there are meter changes or \partial
commands inside of percent repeats, they need to occur in parallel
passages outside of any percent repeat, if necessary in a separate
"timing track".
Labels: -Patch-push Fixed_2_19_24
Status: Fixed
Originally posted by: fedel...@gmail.com
(No comment was entered for this change.)
Status: Verified