Menu
▾
▴
1 Attachments
#3690 ottavation mark aligment should be improved
Originally created by: *anonymous
Originally created by: janek.li...@gmail.com
Originally owned by: k-ohara5...@oco.net
\markup \justify {
Elaine Gould says that ottavation marks should have their center
(i'm not sure if she means the center of the number or the whole “8va”)
aligned to the left edge of the noteheaad (or leftmost accidental,
both options are possible).
}
{
c''
\ottava #1
c''''
c''''
c''''
}
Discussion
Originally posted by: philhud...@gmail.com
In my reading of Gould, page 28, I can only find "Place the numeral just left of the first note to which it applies." Her guidance is not terribly helpful when the text is 8va rather than 8: she almost exclusively adopts the numeral-only sign.
Originally posted by: k-ohara5...@oco.net
If we apply the existing property 'shorten-pair' to both ends of the ottava bracket, we can use it to set the overhangs. The patch also makes 'minimum-length' work even when set to something less than the overhang, to solve issue 4077.
https://codereview.appspot.com/131340043/
Labels: Patch-new
Owner: k-ohara5...@oco.net
Status: Started
Originally posted by: lemzw...@googlemail.com
LGTM. BTW, it would be nice if lilypond could automatically change `8va' to `8' in case the horizontal space is tight. Is this possible?
Originally posted by: PhilEHol...@googlemail.com
Would it be worth considering Issue 3865 and Issue 3866 at the same time?
Originally posted by: pkx1...@gmail.com
I'm getting
--snip--
input/regression/figured-bass.log
@@ -3,8 +3,48 @@
Renaming input to: `/tmp/lilypond-autobuild/input/regression/figured-bass.ly'
Interpreting music...
Preprocessing graphical objects...
+programming error: Grob `BassFigureBracket' has no interface for property `dash-fraction'
+continuing, cross fingers
--snip--
otherwise passes make and make check and a full make doc. There are some reg test diffs, but I am assuming this programming error needs fixing so I won't post any screenshots yet.
Labels: -Patch-new Patch-needs_work
Originally posted by: k-ohara5...@oco.net
Code comments indicate that automatic shortening from "8va" to "8" was the plan all along, but backward-compatibility needs some care, because people have been redefining the markup. This change fits better with issue 3865.
The part of issue 3866 about the ends of the bracket being solid, if the line is dashed, is attempted here.
Labels: -Patch-needs_work Patch-new
Originally posted by: dak@gnu.org
Patchy the autobot says: passes tests. Number of changes where octavation marks are involved, almost all significant improvements making it easier to see which notes are affected.
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
and a full make doc. reg test diff attached
Originally posted by: pkx1...@gmail.com
Patch on countdown for September 2nd
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1...@gmail.com
Patch counted down - please push
Originally posted by: pkx1...@gmail.com
Patch counted down - please push
Labels: -Patch-countdown Patch-push
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Labels: -Patch-push Fixed_2_19_14
Status: Fixed
Originally posted by: ColinPKC...@gmail.com
Commit [r0119c1b84108674cf2b1c72bd8c231d831ce1f0f]
Author: Keith OHara <k-ohara5a5a@oco.net> 2014-08-24 16:54:45
Committer: Keith OHara <k-ohara5a5a@oco.net> 2014-09-06 01:15:44
Status: Verified