Menu

#3559 Patch: Build: Clean up lilypond-book includes.

Verified
nobody
Enhancement
2013-09-29
2013-09-16
Anonymous
No

Originally created by: *anonymous

Originally created by: julien.r...@gmail.com
Originally owned by: julien.r...@gmail.com

Build: Clean up lilypond-book includes.

Instead of using a load of includes across the whole tree,
define only the necessary includes for the local directory.

http://codereview.appspot.com/13553049

Discussion

  • Google Importer

    Google Importer - 2013-09-16

    Originally posted by: julien.r...@gmail.com

    (No comment was entered for this change.)

    Owner: julien.r...@gmail.com

     
  • Google Importer

    Google Importer - 2013-09-16

    Originally posted by: julien.r...@gmail.com

    (No comment was entered for this change.)

    Labels: -Patch-new Patch-needs_work

     
  • Google Importer

    Google Importer - 2013-09-16

    Originally posted by: julien.r...@gmail.com

    Fix docs, topdocs dependencies and includes.

    http://codereview.appspot.com/13553049

    Labels: -Patch-needs_work Patch-new

     
  • Google Importer

    Google Importer - 2013-09-17

    Originally posted by: dak@gnu.org

    Patchy the autobot says: passes tests.  I see differences in flags-default.ly, the main visual differences clearly caused by me using a different METAPOST version for baseline and test (rats\!), but should that affect the metrics?  At any rate, unlikely to be caused by build system changes.  I'll check again next time I have a proper baseline, just to be on the safe side.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2013-09-20

    Originally posted by: pkx1...@gmail.com

    (No comment was entered for this change.)

    Labels: -Patch-review Patch-new

     
  • Google Importer

    Google Importer - 2013-09-21

    Originally posted by: pkx1...@gmail.com

    Patchy the autobot says: passes make, make check and a full make doc.

    Labels: -Patch-new Patch-review

     
  • Google Importer

    Google Importer - 2013-09-21

    Originally posted by: pkx1...@gmail.com

    No diffs reported at all.

    Labels: -Patch-review Patch-countdown

     
  • Google Importer

    Google Importer - 2013-09-23

    Originally posted by: pkx1...@gmail.com

    Patch counted down - please push

    Labels: -Patch-countdown Patch-push

     
  • Google Importer

    Google Importer - 2013-09-24

    Originally posted by: julien.r...@gmail.com

    [rbfdebcb93bebe820c2d5fd6c1bed5c589536472c]

    Labels: -Patch-push Fixed_2_17_27
    Status: Fixed

     
  • Google Importer

    Google Importer - 2013-09-29

    Originally posted by: PhilEHol...@googlemail.com

    (No comment was entered for this change.)

    Status: Verified

     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.