Menu
▾
▴
#3465 Pitched trill layout
Verified
nobody
Ugly
2014-02-20
2013-07-16
Anonymous
No
Originally created by: *anonymous
Originally created by: RalphBug...@gmail.com
Originally owned by: k-ohara5...@oco.net
Timothy Lanfear wrote :
Layout of pitched trills with an interval greater than a third became worse
in 2.17.10.
\version "2.17.10"
\relative c' {
\pitchedTrill f2 \startTrillSpan g [r2] \stopTrillSpan
\pitchedTrill f2 \startTrillSpan a [r2] \stopTrillSpan
\pitchedTrill f2 \startTrillSpan b [r2] \stopTrillSpan
}
**********
Confirmed in 2.16.2 and 2.17.21
Originally posted by: dak@gnu.org
[r7d3d28de0ce6e2f018aff599cecd944d1754fe3c] is the first bad commit
commit [r7d3d28de0ce6e2f018aff599cecd944d1754fe3c]
Author: Mike Solomon <mike@apollinemike.com>
Date: Thu Jan 10 08:54:12 2013 +0100
Makes all side-positioning based on skylines instead of boxes.
The major work is in side-position-interface.cc, with minor
modifications at several places in the code-base to adapt to this.
This allows for snugger positioning of horizontally-oriented
fingerings.
A side-effect of this patch is that side-positioning of all
cross-staff grobs delves into the element list of axis-groups
in order to better guess position, which results in less
collisions (for example, dynamics are less likely to collide
with cross-staff beams).
:040000 040000 [r45ec6973e41bd9ded81019043c8dd95187aa8f90] [r6b0f2b201fef6008f17e12eeab02b7896d99603b] M input
:040000 040000 [r0472461c00067cfeb527c7163f60f8787a477544] [r916e94d5669e7170a80dd039868a0e2937e880f3] M lily
:040000 040000 [re2072fd5160a281d5b16f21905b00bbdb8320dbc] [r5a82f85f2e052a7304747331a8b9fa2443f82836] M scm
Which was supposed to fix issue 2527 and is the same commit responsible for issue 3363, whose fix caused issue 3242 whose fix in turn caused issue 3386.
Cc: mts...@gmail.com
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Labels: -Type-Ugly Type-Critical Regression
Originally posted by: k-ohara5...@oco.net
We could make the pitched-trill engraver acknowledge Stems and Flags, like the fingering engraver does.
http://codereview.appspot.com/12844043
Labels: Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes tests.
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on Countdown for August 17th - 06:00 GMT
Labels: -Patch-review Patch-countdown
Owner: k-ohara5...@oco.net
Status: Started
Originally posted by: k-ohara5...@oco.net
Moving the small note in a pitched trill to avoid Stems and Flags clears the collisions in the example above.
But if the stem points down I do not know what rule to apply. I have never seen a trill with an interval greater than a third. We could have a minimum offset in absence of collisions, or just let the small note line up on the note-column.
Cc: -mts...@gmail.com
Originally posted by: k-ohara5...@oco.net
Of course trills with the usual small intervals have the note shift right to avoid the note-head.
Originally posted by: k-ohara5...@oco.net
New patch puts the small note just to the right of the main note, and moves it further right if needed to clear the note stem or flag (which usually is needed).
http://codereview.appspot.com/12844043
Labels: -Patch-countdown Patch-new
Originally posted by: pkx1...@gmail.com
Passes Make, make check and full make doc
Reg test diff attached
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on countdown for August 21 - 06:00 GMT
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1...@gmail.com
Patch counted down - please push (I think).
(not sure about Janek's comment - i.e. if it refers to this patch or some other related patch, but I am sure you will set the tracker appropriately if I am wrong about pushing)
Labels: -Patch-countdown Patch-push
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Labels: -Patch-push fixed_2_17_25
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Labels: -fixed_2_17_25
Status: Accepted
Originally posted by: k-ohara5...@oco.net
The minimum right-shift, used in case the main note doesn't have a stem or its stem points away from the trill-pitch, was implemented in a way that broke a rule recorded at the top of 'define-grobs.scm'. Here is a legal implementation of the same.
http://codereview.appspot.com/12844043
Labels: Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes make, make check and a full make doc.
Labels: -Patch-new Patch-review
Originally posted by: dak@gnu.org
Relabeling this issue (as it has been reopened for a side issue) as Enhancement rather than Critical since the effect presumably is mostly on documentation and cleanliness of grob definition. The definition is suitably different that giving it a fastpath to 2.17.96 before exposure in master seems uncalled for.
Labels: -Type-Critical Type-Enhancement
Originally posted by: pkx1...@gmail.com
patch on countdown for November 28th - 06:00 GMT
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1...@gmail.com
Patch counted down - please push.
Labels: -Patch-countdown Patch-push
Originally posted by: k-ohara5...@oco.net
commit [r8897ef492ffdc91447d1446411dd9f5ac7b425b4]
Labels: -Patch-push Fixed_2_19_0
Status: Fixed
Originally posted by: k-ohara5...@oco.net
The code in 2.17.26 does violate a "WARNING" (that I would also guess is merely for the sake of documentation) but it is still safer to have a stable version heed the warnings.
Labels: Backport_2_18_1
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified
Originally posted by: dak@gnu.org
Pushed to stable/2.18 as
commit [r2bd4733afa19c43d2e967bc1c228b63ab89803e2]
Author: Keith OHara <k-ohara5a5a@oco.net>
Date: Fri Nov 22 19:50:26 2013 -0800
define-grobs.scm: use a property for TrillPitch offset; issue 3465
Labels: -Type-Enhancement -Backport_2_18_1 Type-Ugly Fixed_2_18_1
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified