Menu
▾
▴
#3403 Patch: follow up issue 2470: make Completion_rest_engraver aware of completionUnit
Originally created by: *anonymous
Originally created by: benko....@gmail.com
Originally owned by: benko....@gmail.com
follow up issue 2470: make Completion_rest_engraver aware of completionUnit
also
- extend completion unit testing to test rests too
- cleanup:
- fix a copy'n'paste typo
- remove unused member
Originally posted by: benko....@gmail.com
(No comment was entered for this change.)
Owner: benko....@gmail.com
Originally posted by: benko....@gmail.com
regtest change in completion-heads-unit.ly expected
Originally posted by: benko....@gmail.com
follow up issue 3402 too
http://codereview.appspot.com/10100043
Originally posted by: pkx1...@gmail.com
Passes Make, make check and a full make doc. Reg test diff attached
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on Countdown for June 12 - 06:00
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1...@gmail.com
Patch counted down - please push
Labels: -Patch-countdown Patch-push
Originally posted by: benko....@gmail.com
pushed to staging as
[r55c25d3fbd92cf20170cba16c3b8cc2616eb39f1] cleanup
[r20dcc09b9736369830680250fb20ca12ca053ba5] issue 3403: make Completion_rest_engraver aware of completionUnit
[r733828c4ac75972c4c470c7eb6780e0d658761f9] extend completion unit testing to test rests too
Originally posted by: benko....@gmail.com
commits reached master
Labels: -Patch-push Fixed_2_17_21
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified