#339 possibly misplaced dot in notehead collision

[Anonymous]

Originally created by: *anonymous

Originally created by: gpermus@gmail.com
Originally owned by: gpermus@gmail.com

Mats:
In the source code that handles collisions of note heads
(lily/note-collision.cc)
I found the following comment:

/* For full collisions, the right hand head may obscure dots, so
    make sure the dotted heads go to the right.  */

It seems that this doesn't happen in the below example.

(However, I seem to remember some related
discussions on the mailing list over the years and I don't remember the
conclusion, so it might be that it was decided to use the current layout and
that the comment is left over from before that decision.)

\version "2.10.20"
\paper{ ragged-right=##t }
\new Staff \relative c' <<
fis4. \\ {e8 e e }
>>

[Google Importer]

Originally posted by: hanw...@gmail.com

I'm not sure if this is a better solution, see

---
\version "2.10.20"
\paper{ ragged-right=##t }
\new Staff \relative c' {

<<fis4. \\ {e8 e e }>>
<<
{
\override NoteColumn #'force-hshift = #1.2
fis4.

}\\ {

e8\noBeam e e }>>
}

---

the proper solution is to move the dot up. I'm not sure how to achieve that in the
current infrastructure, though.

[Google Importer]

Originally posted by: hanw...@gmail.com

Note also that the comment talks about full collisions. This case is a 'half' collision.

[Google Importer]

Originally posted by: gpermus@gmail.com

(No comment was entered for this change.)

Labels: -Priority-Medium Priority-Postponed

[Google Importer]

Originally posted by: hanw...@gmail.com

Andrew Hawryluk <ahawryluk@gmail.com> :

I wrote out an organ accompaniment in LilyPond (to get it onto 4 pages
instead of 13), and it illustrates this situation very well. In eight
separate places there was a major or minor second between a dotted and
undotted note, with the dotted note on a staff space - exactly the
condition that produces the bug shown in the report
(https://code.google.com/p/lilypond/issues/detail?id=339).

In all eight cases, the engraver reversed the noteheads to place the
dotted one on the right. (The equivalent of the LilyPond tweak \once
\override NoteColumn #'force-hshift = some number, maybe 1.4 or 1.5).
Perhaps this should be the way LilyPond handles these cases after all?
Or are there good counter examples where the engraver moved the dot
upward to solve the problem?

The score was "Love Divine, All Loves Excelling", arranged by Mack
Wilberg and published by Oxford University Press.

Andrew

Labels: fixed_2_11_43
Status: Fixed

[Google Importer]

Originally posted by: v.villenave

(No comment was entered for this change.)

Status: Verified