Menu
▾
▴
2 Attachments
#3386 Output crops staff braces when produced with -dpreview
Originally created by: *anonymous
Originally created by: PhilEHol...@googlemail.com
Originally owned by: k-ohara5...@oco.net
See:
http://lilypond.1069038.n5.nabble.com/dpreview-crops-staff-bracket-td145267.html
This affects our documentation badly.
The cited mail thread has the result of git bisect:
git bisect bad
[r7b2cb93fc69c7d7c45f0ae6495f688752efeb107] is the first bad commit
commit [r7b2cb93fc69c7d7c45f0ae6495f688752efeb107]
Author: Mike Solomon <[hidden email]>
Date: Sat Mar 23 19:09:28 2013 +0100
Fixes manual beaming over rests and vertical spacing problem (issue
3242)
Originally posted by: PhilEHol...@googlemail.com
Fixes problem with -dpreveiew cropping staff brackets (Issue 3386)
http://codereview.appspot.com/9894043
Labels: Patch-new
Owner: PhilEHol...@googlemail.com
Status: Started
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: input/regression/instrument-name-groups.ly has squashed together braces
Labels: -Patch-new Patch-needs_work
Originally posted by: pkx1...@gmail.com
(No comment was entered for this change.)
Originally posted by: PhilEHol...@googlemail.com
Strange I didn't pick that up from the pixel check. Thanks, James. Looks like the simplest change would be a revert of that patch set, which was only attempting to provide a tidy-up in any case.
Originally posted by: dak@gnu.org
Maybe you did not get to see it in the pixel check. Much of the "cross-staff" folderol is about breaking circular dependencies. If they are retained (watch for errors/warnings!), LilyPond will break them itself, and evaluation orders are sometimes determined by non-deterministic factors like memory layout. Depending on just whether LilyPond's random choice of breaking circular evaluation was prudent or not, results may or may not be good.
Cc: mts...@gmail.com
Originally posted by: k-ohara5...@oco.net
we can try removing the special-case treatment of the braces
http://codereview.appspot.com/10128043/
Labels: -Patch-needs_work Patch-new
Owner: ---
Originally posted by: pkx1...@gmail.com
This doesn't appear to apply to current master
Labels: -Patch-new Patch-needs_work
Originally posted by: k-ohara5...@oco.net
rebased
Labels: -Patch-needs_work Patch-new
Originally posted by: k-ohara5...@oco.net
(No comment was entered for this change.)
Owner: k-ohara5...@oco.net
Originally posted by: pkx1...@gmail.com
Keith,
Patchy still has trouble applying this to current master.
James
Labels: -Patch-new Patch-needs_work
Originally posted by: k-ohara5...@oco.net
Blockedon: lilypond:3404
Labels: -Patch-needs_work Patch-waiting
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Blockedon: -lilypond:3404
Labels: -Patch-waiting Patch-new
Originally posted by: dak@gnu.org
Patchy the autobot says: Patch does not apply.
Labels: -Patch-new Patch-needs_work
Originally posted by: k-ohara5...@oco.net
Rebased, now on a more stable base.
Expect a clean make check, with no new regtest because this is precisely what the `make check` system is not so good at, while Phil's pixel comparison already spots the cut-off braces in existing tests.
http://codereview.appspot.com/10128043/
Labels: -Patch-needs_work Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes make, make test and a full make doc.
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on countdown for June 15 - 06:00 GMT
Labels: -Patch-review Patch-countdown
Originally posted by: pkx1...@gmail.com
Patch counted down please push.
Labels: -Patch-countdown Patch-push
Originally posted by: k-ohara5...@oco.net
commit [r6318402292c170ef2893b0621eda4f3f140fb6da]
lilypond -dpreview --png system-start-nesting.ly
should produce a .png file that includes the left-hand braces
Labels: -Patch-push Fixed_2_17_21
Cc: -mts...@gmail.com
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified