Menu
▾
▴
#3365 Patch: Create and use uniquify function for removing duplicate Grobs
Originally created by: *anonymous
Originally created by: dak@gnu.org
Originally owned by: dak@gnu.org
Create and use uniquify function for removing duplicate Grobs
As opposed to the previous code, this retains the original order, making
results independent from GUILE's memory allocation algorithms.
Originally posted by: dak@gnu.org
(No comment was entered for this change.)
Owner: dak@gnu.org
Originally posted by: dak@gnu.org
Patchy the autobot says: passes tests.
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on countdown for May 19 - 06:00 GMT
Labels: -Patch-review Patch-countdown
Originally posted by: dak@gnu.org
Just a warning on this one: I'll be rereading the patch carefully again and then likely push it early. The reason is that sifting through random changes from the pixel comparisons for issue 3330 makes it hard to properly evaluate all actually actually related changes. Reviewers can't reasonably be expected to juggle with rebased branches, so I am pushing this early.
It does not remove all interaction between unrelated grobs but at least it removes the impact of memory allocation patterns on a significant part of the output phase. Impact on execution time and memory should be civil.
Originally posted by: dak@gnu.org
Let uniquify work in-place, avoiding extra copies
http://codereview.appspot.com/9243045
Labels: -Patch-countdown Patch-new
Originally posted by: dak@gnu.org
Patchy the autobot says: passes tests.
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes make, make test and a full make doc.
Originally posted by: dak@gnu.org
Pushed to staging as
commit [rdb8b07bb2323afd6fd8b0d9cfc48241f31e870a8]
Author: David Kastrup <dak@gnu.org>
Date: Tue May 14 12:00:08 2013 +0200
Issue 3365: Create and use uniquify function for removing duplicate Grobs
As opposed to the previous code, this retains the original order, making
results independent from GUILE's memory allocation algorithms.
Labels: -Patch-review Fixed_2_17_19
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified