page label inside music does not always have space reserved

Issue Tracker for LilyPond

Brought to you by: fedelibre, hahnjo, philholmes, tdanielsmusic

#3337 page label inside music does not always have space reserved

Status: Accepted

Owner: nobody

Labels: None

Needs:

Patch:

Type: Ugly

Updated: 2013-06-22

Created: 2013-04-28

Creator: Anonymous

Private: No

Originally created by: *anonymous

Originally created by: fedel...@gmail.com

Reported here:
http://lists.gnu.org/archive/html/bug-lilypond/2013-04/msg00157.html

When a page label is refered to inside some music, the corresponding page is not
found. The delayed evaluation happens before the label pages are collected.

Compare:

http://lilypond.org/doc/v2.17/input/regression/collated-files.html#page-label.ly
which reads "A (page ?)", with:

http://lilypond.org/doc/v2.16/input/regression/collated-files.html#page-label.ly
which reads "A (page 3)"

Nicolas

Discussion

Google Importer - 2013-04-28

Originally posted by: dak @gnu.org

Anyone up for bisection?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-28

Originally posted by: PhilEHol...@googlemail.com

On it.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-28

Originally posted by: PhilEHol...@googlemail.com

Well, git bisect shows this to be the culprit:

[r28f3294954eff1f263d3b2e3de1c520f4d2fbdfc] is the first bad commit
commit [r28f3294954eff1f263d3b2e3de1c520f4d2fbdfc]
Author: Mike Solomon <mike@apollinemike.com>
Date: Mon Aug 27 23:47:04 2012 +0200

Improvements in vertical skyline approximations (issue 2148).

Disappointing that the regtests didn't pick this up from 8 months ago.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-28

Originally posted by: dak @gnu.org

And too bad that this is half a billion commits compressed into one.

Though Mike probably has some idea where to look.

Cc: mts...@gmail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-28

Originally posted by: k-ohara5...@oco.net

Wokaround:
\override Score.RehearsalMark #'vertical-skylines = #'()

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-30

Originally posted by: k-ohara5...@oco.net

stencil-integral.cc: use extent if stencil is delayed

http://codereview.appspot.com/9039051

Owner: k-ohara5...@oco.net

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-01

Originally posted by: k-ohara5...@oco.net

(No comment was entered for this change.)

Labels: Patch-new
Cc: -mts...@gmail.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-02

Originally posted by: dak @gnu.org

Patchy the autobot says: passes tests. No user-visible changes.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-04

Originally posted by: k-ohara5...@oco.net

The regression test 'page-label.ly' does print the reference to page 3 after this patch. The `make check` method does not notice the change so it didn't get noticed in the comment above.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-07

Originally posted by: pkx1...@gmail.com

Patch on countdown for May 10 - 06:00 GMT

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-10

Originally posted by: pkx1...@gmail.com

Patch counted down - please push

Labels: -Patch-countdown Patch-push

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-10

Originally posted by: k-ohara5...@oco.net

commit [r3a0bd1fd02ae5efac4023449bcb464f0769832de]

Labels: -Patch-push Fixed_2_17_18
Status: Fixed

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-05-13

Originally posted by: Elu...@gmail.com

(No comment was entered for this change.)

Status: Verified

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-06-22

Originally posted by: k-ohara5...@oco.net

There is a remaining problem so closely related to this that I would like to keep the history together.

If a page-ref lies within a more complicated markup that is placed around music, the skylines around the markup have a gap at the page-ref. Musical notation could possibly overlap the page-number. Issue 3255 has a suggestion to solve this by using the placeholder extent to generate a \with-dimensions tag in the markup.

#(ly:set-option 'debug-skylines )
{ \label #'marker
c'1 ^\markup { Page \page-ref #'marker "8" "?" is referenced here.} }

Summary: page label inside music does not always have space reserved
Owner: ---
Labels: -Regression -Fixed_2_17_18 Type-Ugly
Status: Accepted

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: