Originally created by: *anonymous
Originally created by: mts...@gmail.com
Originally owned by: mts...@gmail.com
Avoids direction checking for cross-staff side-support-elements
Only uses direction if it is not a callback. Otherwise, the callback
may lead to cyclic dependencies.
http://codereview.appspot.com/8557044
Originally posted by: mts...@gmail.com
(No comment was entered for this change.)
Owner: mts...@gmail.com
Originally posted by: pkx1...@gmail.com
input/regression/tablature-full-notation.log
@@ -2,8 +2,28 @@
Renaming input to: `/tmp/lilypond-autobuild/input/regression/tablature-full-notation.ly'
Interpreting music...[8]
Preprocessing graphical objects...
+programming error: Grob `TabNoteHead' has no interface for property `direction'
+continuing, cross fingers
+programming error: Grob `TabNoteHead' has no interface for property `direction'
+continuing, cross fingers
+programming error: Grob `TabNoteHead' has no interface for property `direction'
+continuing, cross fingers
+programming error: Grob `TabNoteHead' has no interface for property `direction'
+continuing, cross fingers
+programming error: Grob `TabNoteHead' has no interface for property `direction'
+continuing, cross fingers
Interpreting music...[8]
Preprocessing graphical objects...
+programming error: Grob `TabNoteHead' has no interface for property `direction'
+continuing, cross fingers
+programming error: Grob `TabNoteHead' has no interface for property `direction'
+continuing, cross fingers
+programming error: Grob `TabNoteHead' has no interface for property `direction'
+continuing, cross fingers
+programming error: Grob `TabNoteHead' has no interface for property `direction'
+continuing, cross fingers
+programming error: Grob `TabNoteHead' has no interface for property `direction'
+continuing, cross fingers
Calculating line breaks...
Drawing systems...
Calculating line breaks...
input/regression/tablature-full-notation.log
Labels: -Patch-new Patch-needs_work
Originally posted by: pkx1...@gmail.com
Passes Make and Make check and full make doc though :)
Originally posted by: mts...@gmail.com
Removes unnecessary check of direction
http://codereview.appspot.com/8557044
Labels: -Patch-needs_work Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes make, make test and a full make doc.
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Patch on countdown for April 25th - 19:00 GMT
Labels: -Patch-review Patch-countdown
Originally posted by: k-ohara5...@oco.net
For scheduling purposes, this is a bug-fix rather than an enhancement.
The regression test added with this patch used to work in ver.2.16,
went bad with the patch for issue 2527 finger-flag collision,
and is fixed again with this patch.
Labels: -Type-Enhancement Type-Ugly Regression
Originally posted by: mts...@gmail.com
Good times with comments.
http://codereview.appspot.com/8557044
Labels: -Patch-countdown Patch-new
Originally posted by: pkx1...@gmail.com
Patchy the autobot says: passes make, make test and a full make doc.
Labels: -Patch-new Patch-review
Originally posted by: pkx1...@gmail.com
Looks like there is still some work on this to be done.
Labels: -Patch-review Patch-needs_work
Originally posted by: k-ohara5...@oco.net
The discussion is about exactly what 'cross-staff' means and maybe recording that in a doc-string, but this patch doesn't change the meaning of 'cross-staff', merely applies it, so I suggest we not require the doc-string be part of the bug-fix.
Labels: -Patch-needs_work Patch-countdown
Originally posted by: pkx1...@gmail.com
Patch counted down - please push
Labels: -Patch-countdown Patch-push
Originally posted by: pkx1...@gmail.com
Patch Counted Down - please push (although you may want to rebase first)
Originally posted by: pkx1...@gmail.com
Patch Counted Down - please push (although you may want to rebase first)
Originally posted by: k-ohara5...@oco.net
I rebased and rechecked and pushed for Mike
commit [r1379aa1e8ce5a5b5d7b2f38be2cecf7c854b1c81]
Labels: -Patch-push Fixed_2_17_19
Status: Fixed
Originally posted by: Elu...@gmail.com
(No comment was entered for this change.)
Status: Verified