#3314 powerChords: powerChordSymbol should be same size of other chords

[Anonymous]

Originally created by: *anonymous

Originally created by: fedel...@gmail.com

Bug report:
https://lists.gnu.org/archive/html/bug-lilypond/2013-04/msg00074.html

%% Snippet
\version "2.14.2"

newPowerChordSymbol = {
  <c g>-\markup { \super "5" }
}

chExceptions = #( append
  ( sequential-music-to-chord-exceptions newPowerChordSymbol #t)
  ignatzekExceptions)

music = \chordmode {c:7 c:1.5 c:sus4}

\new ChordNames \chordmode {
% the 5 is currently much bigger than the 7 or sus4
  \powerChords \music
% it should match the size of the other numbers
  \set chordNameExceptions = #chExceptions \music
}

%% End of snippet

Comment from Harm:

Currently `powerChordSymbol´ is defined in /ly/chord-modifiers.ly and
finally used with `powerChords´ from `/ly/property-init.ly´

`powerChordSymbol´ is defined:

powerChordSymbol = {
  <c g>-\markup { \normal-size-super "5" }
  <c g c'>1-\markup { \normal-size-super "5" }
}

resulting in a normal-sized "5", not like other numbers in chords.

Therefore it is not a bug (it is indeed the intended behaviour),
though, Greg requests to give the "5" the same, smaller size and he
provides a method how to do it.

BTW, Greg refers to 2.14.2, though, it's the same with 2.17.15.

I think it's a legitimate feature request.
And I lean to agree with him.

[Valentin Villenave]

Unless I’m mistaken, this is a trivial thing to fix.
https://codereview.appspot.com/348060043/

[Thomas Morley]

The original patch was

commit f09f236f554124b3830332cfcf2c900f07197b68
Author: Patrick Schmidt PLS@patrick-schmidts-computer.local
Date: Fri Sep 17 11:10:09 2010 +0200

power chord symbol

Added power chord definition, symbol and command to typeset this symbol.

Introducing them with \normal-size-super.

There's a bit discussion here
http://lilypond-s-support-for-tablatures.3383434.n2.nabble.com/Power-chords-td5524246.html#a5524246

Interestingly Patrick's first suggestion uses \super.
Later it's changed to \normal-size-super, without any discussion of this topic, afaict

Maybe worth asking him.

Although, I'd vote for \super ...

[Valentin Villenave]

Yes, and there’s issue #1315 as well. Maybe it was Carl who suggested using normal-size instead? \normal-size-super is used in the definition for \partialJazzMusic (without any additional rationale for that AFAICS), which is a bit messy itself.

[Edit: Oh, apparently Allura doesn’t know how to make inter-ticket links automatically. Oh well.]

[Valentin Villenave]

Fixed as part of [#5449]. Please verify.