LilyIssues / Issues / #3307 Rest positions incorrect with non-standard line count

Google Importer - 2013-04-09

Originally posted by: dak@gnu.org

(No comment was entered for this change.)

Owner: dak@gnu.org
Status: Started

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-09

Originally posted by: dak@gnu.org

Issue 3307: Rest positions incorrect with non-standard line count

Also:

Change rest-on-nonstandard-staff regtest to avoid page overflow

I see several changes, some in relation with even-staff-line staffs,
but also some changes with regard to rest location in multi-voice
situations.

Multimeasure rests are not fabulously consistent with the normal rests.

Basically, the whole situation is appalling.

http://codereview.appspot.com/8580045

Labels: Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-09

Originally posted by: pkx1...@gmail.com

This seems to fail to apply to current master for Patchy.

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-09

Originally posted by: dak@gnu.org

Remove obscure gmon.out file that does not belong in the patch

http://codereview.appspot.com/8580045

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-09

Originally posted by: dak@gnu.org

Typo in expression

http://codereview.appspot.com/8580045

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-09

Originally posted by: dak@gnu.org

Here is a somwhat more extensive test case:
mus = { [r1] -"[r1]" [r1] -"[r1]" [r2] -"[r2]" [r2] }

\new StaffGroup <<
$@(map
     (lambda (n)
       #{
     \new Staff \with { \override StaffSymbol.line-count = $n }
     { \mus << \mus \\ \mus >> }
       #})
     (iota 9))
>>

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-09

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc. Reg test diffs are here https://www.yousendit.com/download/UVJpNWNtRSs1UjVsQXNUQw

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: dak@gnu.org

Rename function, some cleanup/change, make regtest same as previous

http://codereview.appspot.com/8580045

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: dak@gnu.org

Patchy the autobot says: First rests on third and fourth system in rest-on-nonstandard-staff avoid the staffline. The expected warnings in this file are not encountered. Huh? From the command line, I trigger them. tablature-full-notation _is_ changed, but only with normal rests. Church rests are still left as before, which is unpretty. rhythmic-staff.ly also has a whole rest that is off the line without good reason.

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: dak@gnu.org

Restore regtest, fix thinko.

http://codereview.appspot.com/8580045

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: pkx1...@gmail.com

Passes Make and make check and full make doc.

Reg test here

https://www.yousendit.com/download/UVJpTG0ySysxUUI3czlVag

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: dak@gnu.org

For empty staffs, full rests should not get offset

http://codereview.appspot.com/8580045

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: dak@gnu.org

Patchy the autobot says: passes tests. The longa rests in rest-on-nonstandard-staff in the fourth system look awkwardly positioned. However, they are consistent with breve and whole rest positions, and those appear reasonable.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: pkx1...@gmail.com

Passes Make and make check and full make doc

Reg test here:

https://www.yousendit.com/download/UVJpTG05OW5laFM1aWNUQw

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: dak@gnu.org

Make MultiMeasureRests use the same positioning mechanism as normal rests

http://codereview.appspot.com/8580045

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: dak@gnu.org

Patchy the autobot says: Church rests are consistently positioned too high in five-line staves

Labels: -Patch-new Patch-needs_work

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: dak@gnu.org

Make church rests as pretty as we can with nonstandard staffs and standard glyphs

http://codereview.appspot.com/8580045

Labels: -Patch-needs_work Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: dak@gnu.org

Patchy the autobot says: passes tests. All changes look reasonable now.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: dak@gnu.org

Make church rest top alignment work independently from font-size

http://codereview.appspot.com/8580045

Labels: -Patch-review Patch-new

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: dak@gnu.org

Turns out that tablature-full-notation looks less flimsy with

\override Rest.font-size = #(magnification->font-size 1.5)
\override MultiMeasureRest.font-size = #(magnification->font-size 1.5)

Maybe something like that should be the default.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-10

Originally posted by: dak@gnu.org

Patchy the autobot says: passes tests.

Labels: -Patch-new Patch-review

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-11

Originally posted by: pkx1...@gmail.com

Patch on countdown for April 14th - 19:00 GMT

Labels: -Patch-review Patch-countdown

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-12

Originally posted by: k-ohara5...@oco.net

The regtest changes are a mix of good and bad:

The reported bug is fixed. Issue 3197 is fixed.
Whole rests using [r1] in voice one are put in the right place (rest-dot-position.ly)

Full measure rests [r1] in voice two are in the wrong place (prefatory-separation.ly)
Quarter and eight rests on staves with even line-count are in the wrong place.

I looked in Ted Ross' book for standard placement on whole rests (image) but for the shorter I found only "even when the eighth rest's position is altered, the dot at the end of the hook falls in a space, never on a staff line."

Changing the default positions of rests would not be a big deal, except that we need to place the rests by hand whenever there is a collision with full-measure rests (issue 3043).

Rests.png

rossRest.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-13

Originally posted by: dak@gnu.org

Obviously "mix of good and bad" is not what I've been aiming for, and all changes _are_ deliberate. Since I don't have _any_ music typesetting book available (well, apart from an old accordion-related text more concerned with orchestration than notation), I have to fly by gut feeling.

So here are the "principles" I have been using; please point out where the literature indicates either my approach or the results are wrong:

a) I don't distinguish the vertical position of multimeasure (wholebar) rests and ordinary rests. That's a significant change to previously. There is one exception: church rests are positioned somewhat differently since they need to form a group.

b) only half-note rests or longer are placed in relation to bar lines. Most important use cases are drum staves with an even number of lines and tablature staves with full tablature. There has been no satisfactory feedback on that decision so far; we might want to publish at least on user and developer list an explicit request. Rationale: for tablature with its 1.5 staff line distance, the existing rest glyphs don't fall into a proper pattern anyway. We could create new glyphs or use a larger version of the existing glyphs (they look aenemic, but scaling them up in size will not just make their height match the staff better but also will make them fat, in contrast to the rather skinny tablature notes). But at any rate, matching to a non-centric staff position looks more distracting than just centring irrespective of the lines. Now tablature with its weird staff distance makes a weak case for staff alignment with existing glyphs. Drum staves with even number of lines could make a stronger case, except that we are totally lacking relevant input again. My own taste prefers centring.

c) whole and half note rests occupy the same staff space unless that makes one hang in the air.

d) There are some offsets gathering the vertical positioning of multi-voice rests, and then the wanted staff line is found from there. We can tweak the rules and offsets to match the five-line cases spelt out in theory, but we still have to make a decision about what to do with other staves: aim for fixed offset, or aim for bottom placement?

At any rate, seems like we still need feedback on the visuals of this change. Some things can get likely be sorted out with existing feedback, but some are really unclear and it makes no sense to stall indefinitely.

Labels: -Patch-countdown Patch-review Needs-design

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Google Importer - 2013-04-13

Originally posted by: lemzw...@googlemail.com

Well, someone with too much time should provide real-world scans :-)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rest positions incorrect with non-standard line count

Issue Tracker for LilyPond

Searches

Help

#3307 Rest positions incorrect with non-standard line count

Related

Discussion