#3290 Appendix 4, Predefined fretboard diagram: wrong chords are displayed

[Anonymous]

Originally created by: *anonymous

Originally created by: fedel...@gmail.com
Originally owned by: dak@gnu.org

Reported on bug-lilypond:
http://lists.gnu.org/archive/html/bug-lilypond/2013-03/msg00146.html

In NR Appendix 4:
http://www.lilypond.org/doc/v2.17/Documentation/notation/predefined-fretboard-diagrams.html

the chords are not displayed correctly: this is true at least for guitar and mandolin, and probably for ukulele too (I don't know this instrument).

I think this is just a problem with the files in Documentation/included.
If I replace \context with \new, the chords are displayed correctly.
Maybe a developer can explain why... Also, staff is not printed when using \context.

[Google Importer]

Originally posted by: fedel...@gmail.com

(No comment was entered for this change.)

Labels: Type-Documentation

[Google Importer]

Originally posted by: dak@gnu.org

This is a consequence of
commit [r08e0e65cb2905bfe9ded5407662d9af3b0b99283]
Author: David Kastrup <dak@gnu.org>
Date:   Tue Jul 24 08:22:11 2012 +0200

    Issue 2664: Add Staff alias to FretBoards, let convert-ly set Staff.stringTuning

Likely added in 2.15.42.

Since FretBoards now counts as Staff, \context Staff reuses the existing FretBoards context, so the notes appear twice and are not recognized by the predefined fretboards.  I am not sure why there is an actual Staff context added.  Can't imagine the notes being of much use here.

Putting \new everywhere should be fine.

Owner: dak@gnu.org
Status: Started

[Google Importer]

Originally posted by: dak@gnu.org

Issue 3290: Appendix 4, Predefined fretboard diagram: wrong chords are displayed

http://codereview.appspot.com/8320043

Labels: Patch-new

[Google Importer]

Originally posted by: dak@gnu.org

fretted-strings.itely also has a few of those cases.  Replace more than just the necessary ones.

http://codereview.appspot.com/8320043

[Google Importer]

Originally posted by: pkx1...@gmail.com

Patchy the autobot says: passes make, make test and a full make doc.

Labels: -Patch-new Patch-review

[Google Importer]

Originally posted by: dak@gnu.org

I don't see that this fix calls for further review and it needs time to trickle into translations, so pushing to staging as
commit [r25580682a08194862532dc53636148fb52de94c2]
Author: David Kastrup <dak@gnu.org>
Date:   Wed Apr 3 17:41:02 2013 +0200

    Issue 3290/2: \context -> \new in fretted-strings.itely
   
    The combination
   
       \context FretBoards ...
       \context Staff
   
    ends up in the same context due to FretBoards being an alias for
    Staff.  To avoid inconsistencies, not just those occurences of
    \context which are really necessary are replaced.

commit [r236963781bc8cefaeb4e59b30e5e17fefafe0634]
Author: David Kastrup <dak@gnu.org>
Date:   Wed Apr 3 17:30:25 2013 +0200

    Issue 3290: Appendix 4, Predefined fretboard diagram: wrong chords are displayed

Labels: -Patch-review Fixed_2_17_16
Status: Fixed

[Google Importer]

Originally posted by: Elu...@gmail.com

(No comment was entered for this change.)

Status: Verified

[Christopher Heckman]

It's isn't just the website; the boards for augmented and diminished chords are calculated incorrectly.

\include "predefined-guitar-fretboards.ly"
\new FretBoards \chordmode { b:dim f:aug aes:aug g:dim }

The F aug chord is incorrect; it actually shows a G augmented chord. In all four cases, the numbers at the bottom do not match up with the diagram. The B dim number should be 2343, the A flat aug 032110, and G dim should be 3131.

Others might be incorrect as well.

--- Christopher Heckman

[Anonymous]

Christopher,

As this issue is closed as 'fixed', I'm going to pass this onto the 'dev' list for comment (as I have no knowledge of Fretboards) and, if required, will create a new ticket.

Thanks for taking the time to follow up.

James

[David Kastrup]

This is very much unrelated to what this issue is about. Some guitar players might want to look the named chords over.